| Message ID | 20221117035100.2944812-1-cuigaosheng1@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | scsi: snic: Fix possible UAF in snic_tgt_create | expand |
Gaosheng, > Smatch report warning as follows: > > drivers/scsi/snic/snic_disc.c:307 snic_tgt_create() warn: > '&tgt->list' not removed from list Applied to 6.2/scsi-staging, thanks!
On Thu, 17 Nov 2022 11:51:00 +0800, Gaosheng Cui wrote: > Smatch report warning as follows: > > drivers/scsi/snic/snic_disc.c:307 snic_tgt_create() warn: > '&tgt->list' not removed from list > > If device_add() fails in snic_tgt_create(), tgt will be freed, but > tgt->list will not be removed from snic->disc.tgt_list, then list > traversal may cause UAF. > > [...] Applied to 6.2/scsi-queue, thanks! [1/1] scsi: snic: Fix possible UAF in snic_tgt_create https://git.kernel.org/mkp/scsi/c/e118df492320
diff --git a/drivers/scsi/snic/snic_disc.c b/drivers/scsi/snic/snic_disc.c index 9b2b5f8c23b9..8fbf3c1b1311 100644 --- a/drivers/scsi/snic/snic_disc.c +++ b/drivers/scsi/snic/snic_disc.c @@ -304,6 +304,9 @@ snic_tgt_create(struct snic *snic, struct snic_tgt_id *tgtid) ret); put_device(&snic->shost->shost_gendev); + spin_lock_irqsave(snic->shost->host_lock, flags); + list_del(&tgt->list); + spin_unlock_irqrestore(snic->shost->host_lock, flags); kfree(tgt); tgt = NULL;
Smatch report warning as follows: drivers/scsi/snic/snic_disc.c:307 snic_tgt_create() warn: '&tgt->list' not removed from list If device_add() fails in snic_tgt_create(), tgt will be freed, but tgt->list will not be removed from snic->disc.tgt_list, then list traversal may cause UAF. Fix by removeing it from snic->disc.tgt_list before free(). Fixes: c8806b6c9e82 ("snic: driver for Cisco SCSI HBA") Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> --- drivers/scsi/snic/snic_disc.c | 3 +++ 1 file changed, 3 insertions(+)