| Message ID | 20221201174328.870152-15-manivannan.sadhasivam@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ufs: qcom: Add HS-G4 support | expand |
On Thu, Dec 01 2022 at 09:45 -0800, Manivannan Sadhasivam wrote: >In the reset assert and deassert callbacks, the supplied "id" is not used >at all and only the hba reset is performed all the time. So there is no >reason to use a WARN_ON on the "id". > >Reviewed-by: Andrew Halaney <ahalaney@redhat.com> >Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> >--- > drivers/ufs/host/ufs-qcom.c | 4 ---- > 1 file changed, 4 deletions(-) > LGTM. Reviewed-by: Asutosh Das <quic_asutoshd@quicinc.com> >diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c >index 7cd996ac180b..8bb0f4415f1a 100644 >--- a/drivers/ufs/host/ufs-qcom.c >+++ b/drivers/ufs/host/ufs-qcom.c >@@ -895,8 +895,6 @@ ufs_qcom_reset_assert(struct reset_controller_dev *rcdev, unsigned long id) > { > struct ufs_qcom_host *host = rcdev_to_ufs_host(rcdev); > >- /* Currently this code only knows about a single reset. */ >- WARN_ON(id); > ufs_qcom_assert_reset(host->hba); > /* provide 1ms delay to let the reset pulse propagate. */ > usleep_range(1000, 1100); >@@ -908,8 +906,6 @@ ufs_qcom_reset_deassert(struct reset_controller_dev *rcdev, unsigned long id) > { > struct ufs_qcom_host *host = rcdev_to_ufs_host(rcdev); > >- /* Currently this code only knows about a single reset. */ >- WARN_ON(id); > ufs_qcom_deassert_reset(host->hba); > > /* >-- >2.25.1 >
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 7cd996ac180b..8bb0f4415f1a 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -895,8 +895,6 @@ ufs_qcom_reset_assert(struct reset_controller_dev *rcdev, unsigned long id) { struct ufs_qcom_host *host = rcdev_to_ufs_host(rcdev); - /* Currently this code only knows about a single reset. */ - WARN_ON(id); ufs_qcom_assert_reset(host->hba); /* provide 1ms delay to let the reset pulse propagate. */ usleep_range(1000, 1100); @@ -908,8 +906,6 @@ ufs_qcom_reset_deassert(struct reset_controller_dev *rcdev, unsigned long id) { struct ufs_qcom_host *host = rcdev_to_ufs_host(rcdev); - /* Currently this code only knows about a single reset. */ - WARN_ON(id); ufs_qcom_deassert_reset(host->hba); /*