| Message ID | 20221209084130.31805-1-lukas.bulwahn@gmail.com (mailing list archive) |
|---|---|
| State | Deferred |
| Headers | show |
| Series | scsi: remove left-over due to now gone pktcdvd shortcomings | expand |
Hi Lukas,
I love your patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on jejb-scsi/for-next linus/master v6.1-rc8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Lukas-Bulwahn/scsi-remove-left-over-due-to-now-gone-pktcdvd-shortcomings/20221209-164340
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link: https://lore.kernel.org/r/20221209084130.31805-1-lukas.bulwahn%40gmail.com
patch subject: [PATCH] scsi: remove left-over due to now gone pktcdvd shortcomings
config: x86_64-rhel-8.3-rust
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/f744be58fe1bbc94c5b17ccafbf0be5620f25c16
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Lukas-Bulwahn/scsi-remove-left-over-due-to-now-gone-pktcdvd-shortcomings/20221209-164340
git checkout f744be58fe1bbc94c5b17ccafbf0be5620f25c16
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> ERROR: modpost: "scsi_device_from_queue" [drivers/block/pktcdvd.ko] undefined!
On Fri, Dec 09, 2022 at 09:41:30AM +0100, Lukas Bulwahn wrote: > Commit f40eb99897af ("pktcdvd: remove driver.") removes the pktcdvd driver, > including the config CDROM_PKTCDVD and CDROM_PKTCDVD_WCACHE, and the uapi > header file. > > Remove some further unneeded left-over due to now gone pktcdvd shortcomings > in the scsi library. Right now the removal is only in the block tree, so this will have to wait until that and the scsi tree are merged to mainline. I was actually going to send this patch at that point, but we can just pick up yours now: Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 9ed1ebcb7443..d74536d4cc94 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -2018,14 +2018,6 @@ struct scsi_device *scsi_device_from_queue(struct request_queue *q) return sdev; } -/* - * pktcdvd should have been integrated into the SCSI layers, but for historical - * reasons like the old IDE driver it isn't. This export allows it to safely - * probe if a given device is a SCSI one and only attach to that. - */ -#ifdef CONFIG_CDROM_PKTCDVD_MODULE -EXPORT_SYMBOL_GPL(scsi_device_from_queue); -#endif /** * scsi_block_requests - Utility function used by low-level drivers to prevent
Commit f40eb99897af ("pktcdvd: remove driver.") removes the pktcdvd driver, including the config CDROM_PKTCDVD and CDROM_PKTCDVD_WCACHE, and the uapi header file. Remove some further unneeded left-over due to now gone pktcdvd shortcomings in the scsi library. Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- drivers/scsi/scsi_lib.c | 8 -------- 1 file changed, 8 deletions(-)