diff mbox series

[v1,1/1] scsi: fnic: Switch to use %ptTs

Message ID 20230314145813.66112-1-andriy.shevchenko@linux.intel.com (mailing list archive)
State Accepted
Headers show
Series [v1,1/1] scsi: fnic: Switch to use %ptTs | expand

Commit Message

Andy Shevchenko March 14, 2023, 2:58 p.m. UTC 
Use %ptTs instead of open-coded variant to print contents
of time64_t type in human readable form.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/scsi/fnic/fnic_trace.c | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

Comments

Martin K. Petersen March 17, 2023, 3:08 a.m. UTC | #1 
Andy,

> Use %ptTs instead of open-coded variant to print contents
> of time64_t type in human readable form.

Applied to 6.4/scsi-staging, thanks!
Martin K. Petersen March 24, 2023, 9:06 p.m. UTC | #2 
On Tue, 14 Mar 2023 16:58:13 +0200, Andy Shevchenko wrote:

> Use %ptTs instead of open-coded variant to print contents
> of time64_t type in human readable form.
> 
> 

Applied to 6.4/scsi-queue, thanks!

[1/1] scsi: fnic: Switch to use %ptTs
      https://git.kernel.org/mkp/scsi/c/58b42c949b30
diff mbox series

Patch

diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c
index e03967463561..f3c3a26a1384 100644
--- a/drivers/scsi/fnic/fnic_trace.c
+++ b/drivers/scsi/fnic/fnic_trace.c
@@ -781,28 +781,21 @@  void copy_and_format_trace_data(struct fc_trace_hdr *tdata,
 				fnic_dbgfs_t *fnic_dbgfs_prt, int *orig_len,
 				u8 rdata_flag)
 {
-	struct tm tm;
 	int j, i = 1, len;
-	char *fc_trace, *fmt;
 	int ethhdr_len = sizeof(struct ethhdr) - 1;
 	int fcoehdr_len = sizeof(struct fcoe_hdr);
 	int fchdr_len = sizeof(struct fc_frame_header);
 	int max_size = fnic_fc_trace_max_pages * PAGE_SIZE * 3;
+	char *fc_trace;
 
 	tdata->frame_type = tdata->frame_type & 0x7F;
 
 	len = *orig_len;
 
-	time64_to_tm(tdata->time_stamp.tv_sec, 0, &tm);
-
-	fmt = "%02d:%02d:%04ld %02d:%02d:%02d.%09lu ns%8x       %c%8x\t";
-	len += scnprintf(fnic_dbgfs_prt->buffer + len,
-		max_size - len,
-		fmt,
-		tm.tm_mon + 1, tm.tm_mday, tm.tm_year + 1900,
-		tm.tm_hour, tm.tm_min, tm.tm_sec,
-		tdata->time_stamp.tv_nsec, tdata->host_no,
-		tdata->frame_type, tdata->frame_len);
+	len += scnprintf(fnic_dbgfs_prt->buffer + len, max_size - len,
+			 "%ptTs.%09lu ns%8x       %c%8x\t",
+			 &tdata->time_stamp.tv_sec, tdata->time_stamp.tv_nsec,
+			 tdata->host_no, tdata->frame_type, tdata->frame_len);
 
 	fc_trace = (char *)FC_TRACE_ADDRESS(tdata);