| Message ID | 20230322092713.6961-1-ranjan.kumar@broadcom.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | mpt3sas: Remove logging BIOS version in the kernel log | expand |
Hi Ranjan! > It is done to avoid ambiguity between BIOS and UEFI version. > Management tools can be used for getting proper version information Not everyone uses management tools. Why not print the UEFI version as well?
Martin, The only proper way to print UEFI Boot Services Driver version and legacy x86 OpROM version is to upload those image headers from flash and retrieve the version, various generation of the controllers have various type of image headers hence a good amount of code needs to be added to the driver to display them properly and associated feature maintenance, so we thought it is better to push that to applications space, if you think the added code is worth the value it provides, we can add it in the future, we would prefer to remove the current way of showing a version in that message. Thanks Sathya On Fri, Mar 24, 2023 at 6:51 PM Martin K. Petersen <martin.petersen@oracle.com> wrote: > > > Hi Ranjan! > > > It is done to avoid ambiguity between BIOS and UEFI version. > > Management tools can be used for getting proper version information > > Not everyone uses management tools. Why not print the UEFI version as > well? > > -- > Martin K. Petersen Oracle Linux Engineering
Sathya, > The only proper way to print UEFI Boot Services Driver version and > legacy x86 OpROM version is to upload those image headers from flash > and retrieve the version, various generation of the controllers have > various type of image headers hence a good amount of code needs to be > added to the driver to display them properly and associated feature > maintenance, so we thought it is better to push that to applications > space OK. As long as the firmware version is printed, I guess we can live without the legacy BIOS.
On Wed, 22 Mar 2023 14:57:13 +0530, Ranjan Kumar wrote: > It is done to avoid ambiguity between BIOS and UEFI version. > Management tools can be used for getting proper version information > > Applied to 6.4/scsi-queue, thanks! [1/1] mpt3sas: Remove logging BIOS version in the kernel log https://git.kernel.org/mkp/scsi/c/3fc5d6d6dcac
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index 2ee9ea57554d..4bd570204749 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -4761,21 +4761,15 @@ _base_display_ioc_capabilities(struct MPT3SAS_ADAPTER *ioc) int i = 0; char desc[17] = {0}; u32 iounit_pg1_flags; - u32 bios_version; - bios_version = le32_to_cpu(ioc->bios_pg3.BiosVersion); strncpy(desc, ioc->manu_pg0.ChipName, 16); - ioc_info(ioc, "%s: FWVersion(%02d.%02d.%02d.%02d), ChipRevision(0x%02x), BiosVersion(%02d.%02d.%02d.%02d)\n", + ioc_info(ioc, "%s: FWVersion(%02d.%02d.%02d.%02d), ChipRevision(0x%02x)\n", desc, (ioc->facts.FWVersion.Word & 0xFF000000) >> 24, (ioc->facts.FWVersion.Word & 0x00FF0000) >> 16, (ioc->facts.FWVersion.Word & 0x0000FF00) >> 8, ioc->facts.FWVersion.Word & 0x000000FF, - ioc->pdev->revision, - (bios_version & 0xFF000000) >> 24, - (bios_version & 0x00FF0000) >> 16, - (bios_version & 0x0000FF00) >> 8, - bios_version & 0x000000FF); + ioc->pdev->revision); _base_display_OEMs_branding(ioc);
It is done to avoid ambiguity between BIOS and UEFI version. Management tools can be used for getting proper version information Signed-off-by: Ranjan Kumar <ranjan.kumar@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_base.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)