From patchwork Wed Jun 7 11:38:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nilesh Javali X-Patchwork-Id: 13270505 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9053C7EE23 for ; Wed, 7 Jun 2023 11:38:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240163AbjFGLi5 (ORCPT ); Wed, 7 Jun 2023 07:38:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239248AbjFGLiz (ORCPT ); Wed, 7 Jun 2023 07:38:55 -0400 Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9051719BF for ; Wed, 7 Jun 2023 04:38:54 -0700 (PDT) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 357BIgDs030172 for ; Wed, 7 Jun 2023 04:38:53 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=dyfPdzLqwFL6ZOoIlqw8rNFJVeWKCwnioohjvaEsbmQ=; b=PaLtGm/494qKBhRF43dN/iqdoda+Q0ma+BP25hFYw5PWYzC4ZidRr2jL3R81dn6j/Iir vD48HE35V4IjShD7RKD0ndgKm0ezkglDSx1eZsdbvEPIE2LmtK0YUvDWXUUiogvxYzQx TaXfHPcUi60m9csJ/sq1y60rtCfbmD3WevCfIDi+4r8oMRssDMr2cEyrHIyZVSkx953J pc+uEdpCBiPUJejjPEZ1w2MLGCEp1+b0qYFEDKyIOTRZtx6VzDdSoLFNAyPOzrPlwwdC gOb7urQBClwDN5G+2cP4WUhz1JeI5LMBEnDSlk3ImvqQs/fZXZ1mNc23yWzhVRRWvlw6 2w== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3r2a75afeh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Wed, 07 Jun 2023 04:38:53 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Wed, 7 Jun 2023 04:38:51 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Wed, 7 Jun 2023 04:38:51 -0700 Received: from localhost.marvell.com (unknown [10.30.46.195]) by maili.marvell.com (Postfix) with ESMTP id A761B3F706A; Wed, 7 Jun 2023 04:38:49 -0700 (PDT) From: Nilesh Javali To: CC: , , , Subject: [PATCH v2 2/8] qla2xxx: klocwork - Fix potential null pointer dereference Date: Wed, 7 Jun 2023 17:08:37 +0530 Message-ID: <20230607113843.37185-3-njavali@marvell.com> X-Mailer: git-send-email 2.23.1 In-Reply-To: <20230607113843.37185-1-njavali@marvell.com> References: <20230607113843.37185-1-njavali@marvell.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: OV-XGtsV7xjkgo25kNdxtM9BepBfy2NZ X-Proofpoint-GUID: OV-XGtsV7xjkgo25kNdxtM9BepBfy2NZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-07_06,2023-06-07_01,2023-05-22_02 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org From: Bikash Hazarika Klocwork tool reported 'cur_dsd' may be dereferenced. Add fix to validate pointer before dereferencing the pointer. Cc: stable@vger.kernel.org Signed-off-by: Bikash Hazarika Signed-off-by: Nilesh Javali Reviewed-by: Himanshu Madhani --- v2: - check tot_dsds to suppress kw warning. drivers/scsi/qla2xxx/qla_iocb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 6acfdcc48b16..a1675f056a5c 100644 --- a/drivers/scsi/qla2xxx/qla_iocb.c +++ b/drivers/scsi/qla2xxx/qla_iocb.c @@ -607,7 +607,8 @@ qla24xx_build_scsi_type_6_iocbs(srb_t *sp, struct cmd_type_6 *cmd_pkt, put_unaligned_le32(COMMAND_TYPE_6, &cmd_pkt->entry_type); /* No data transfer */ - if (!scsi_bufflen(cmd) || cmd->sc_data_direction == DMA_NONE) { + if (!scsi_bufflen(cmd) || cmd->sc_data_direction == DMA_NONE || + tot_dsds == 0) { cmd_pkt->byte_count = cpu_to_le32(0); return 0; }