From patchwork Wed Jun 7 11:38:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nilesh Javali X-Patchwork-Id: 13270509 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB01C7EE23 for ; Wed, 7 Jun 2023 11:39:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240391AbjFGLjL (ORCPT ); Wed, 7 Jun 2023 07:39:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240352AbjFGLjH (ORCPT ); Wed, 7 Jun 2023 07:39:07 -0400 Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AC011730 for ; Wed, 7 Jun 2023 04:39:03 -0700 (PDT) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 357BIfP5030111 for ; Wed, 7 Jun 2023 04:39:03 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=sh212+aZKOP180yWPyYoPPpifSn/ACLRyelMjM3Dym4=; b=EvzDCROVwAInIEOw1h2rXZjRpsYopiYQt0GEXy7OkwCJkWt6mhsnuXhgC+HnMckhvbbV GqyLGkwVClBPm6YAvDLQ3lHdaWgPodKMM9irP2PcBXn3i+VAc2b1mWFkLoeA4IMWfi+W HwI1vkDKgEOV5ySEWQQ/lFyBxwrn8NmadoeHO7XuIExu1dgZMV/gZ4x/RAhgK8D31rVV i6agPmavEgFZPMo3V3ComRMvCUnyca6Rw1WR2uo54wWgAfAXuoATeGxsRceIq7LITchm vwjMLLhLOFlaZW564MLKeCysPxLnNquHoLYXEEY//vsreiY3tPVT6fkC3ZwjMRisa4PD 2g== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3r2a75affn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Wed, 07 Jun 2023 04:39:03 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Wed, 7 Jun 2023 04:39:00 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Wed, 7 Jun 2023 04:39:00 -0700 Received: from localhost.marvell.com (unknown [10.30.46.195]) by maili.marvell.com (Postfix) with ESMTP id 1F7D03F706F; Wed, 7 Jun 2023 04:38:58 -0700 (PDT) From: Nilesh Javali To: CC: , , , Subject: [PATCH v2 6/8] qla2xxx: klocwork - pointer may be dereferenced Date: Wed, 7 Jun 2023 17:08:41 +0530 Message-ID: <20230607113843.37185-7-njavali@marvell.com> X-Mailer: git-send-email 2.23.1 In-Reply-To: <20230607113843.37185-1-njavali@marvell.com> References: <20230607113843.37185-1-njavali@marvell.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: K9doygX-mdOCHlJsgaLmQV-NhkOPkRSt X-Proofpoint-GUID: K9doygX-mdOCHlJsgaLmQV-NhkOPkRSt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-07_06,2023-06-07_01,2023-05-22_02 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org From: Shreyas Deodhar Klocwork tool reported pointer 'rport' returned from call to function 'fc_bsg_to_rport' may be NULL and will be dereferenced. Add a fix to validate rport before dereferencing. Cc: stable@vger.kernel.org Signed-off-by: Shreyas Deodhar Signed-off-by: Nilesh Javali Reviewed-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_bsg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c index c928b27061a9..19bb64bdd88b 100644 --- a/drivers/scsi/qla2xxx/qla_bsg.c +++ b/drivers/scsi/qla2xxx/qla_bsg.c @@ -2996,6 +2996,8 @@ qla24xx_bsg_request(struct bsg_job *bsg_job) if (bsg_request->msgcode == FC_BSG_RPT_ELS) { rport = fc_bsg_to_rport(bsg_job); + if (!rport) + return ret; host = rport_to_shost(rport); vha = shost_priv(host); } else {