diff mbox series

scsi: aacraid: avoid -Warray-bounds warning

Message ID 20230703114851.1194510-1-arnd@kernel.org (mailing list archive)
State Accepted
Headers show
Series scsi: aacraid: avoid -Warray-bounds warning | expand

Commit Message

Arnd Bergmann July 3, 2023, 11:48 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

The one-element array in aac_aifcmd is actually meant as a flexible array,
and causes an overflow warning that can be avoided using the normal
flex arrays:

drivers/scsi/aacraid/commsup.c:1166:17: error: array index 1 is past the end of the array (that has type 'u8[1]' (aka 'unsigned char[1]'), cast to '__le32 *' (aka 'unsigned int *')) [-Werror,-Warray-bounds]
                                (((__le32 *)aifcmd->data)[1] == cpu_to_le32(3));
                                            ^             ~

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/scsi/aacraid/aacraid.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen July 6, 2023, 1:42 a.m. UTC | #1 
Arnd,

> The one-element array in aac_aifcmd is actually meant as a flexible
> array, and causes an overflow warning that can be avoided using the
> normal flex arrays:

Applied to 6.5/scsi-staging, thanks!
diff mbox series

Patch

diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h
index 7c6efde75da66..73b6ac0c01f54 100644
--- a/drivers/scsi/aacraid/aacraid.h
+++ b/drivers/scsi/aacraid/aacraid.h
@@ -2618,7 +2618,7 @@  struct aac_hba_info {
 struct aac_aifcmd {
 	__le32 command;		/* Tell host what type of notify this is */
 	__le32 seqnum;		/* To allow ordering of reports (if necessary) */
-	u8 data[1];		/* Undefined length (from kernel viewpoint) */
+	u8 data[];		/* Undefined length (from kernel viewpoint) */
 };
 
 /**