From patchwork Wed Sep 20 13:54:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Le Moal X-Patchwork-Id: 13392817 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09CE5CE79D3 for ; Wed, 20 Sep 2023 13:56:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236617AbjITN4M (ORCPT ); Wed, 20 Sep 2023 09:56:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236632AbjITNzk (ORCPT ); Wed, 20 Sep 2023 09:55:40 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E096BF2; Wed, 20 Sep 2023 06:55:19 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C02E1C43391; Wed, 20 Sep 2023 13:55:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695218119; bh=lmI/yQR3mXjTNExyBjMUNn39lcUmMCzc9DGZmawQH6U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JpbQtQgmZNdIFLR1rn4IeYtRyHwBevQCcwh2WAZw5JmmEjUrFAdRW2yMPT8IMOOC0 saCbElmebUl5SJpERXrXTNOa8dzULaDE+YVBOoEhGv7rLl9oZifbIYZr0N/Np25S5z Pkx+G312q56ogw8gUvNNXR4vBa1zp97auDOtA0kCDWApJDnlX9IUdjgwZcJKAryMEV CgqSrIQZ+6L3cXfgPTW6B0jYdUInskdsTgUILGKYE8XQAJLftYeHpVh8SZjG6W/YGl QDZYs3M0iJ5R/e4wzmlc6qVTpAG6Uc0EIfq974GR3jGaoz7i+8FSkL7iVS0GBIy3U8 r+yGKzyVJJEPA== From: Damien Le Moal To: linux-ide@vger.kernel.org Cc: linux-scsi@vger.kernel.org, "Martin K . Petersen" , John Garry , Rodrigo Vivi , Paul Ausbeck , Kai-Heng Feng , Joe Breuer , Geert Uytterhoeven , Chia-Lin Kao Subject: [PATCH v4 20/23] ata: libata-sata: Improve ata_sas_slave_configure() Date: Wed, 20 Sep 2023 22:54:36 +0900 Message-ID: <20230920135439.929695-21-dlemoal@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230920135439.929695-1-dlemoal@kernel.org> References: <20230920135439.929695-1-dlemoal@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Change ata_sas_slave_configure() to return the return value of ata_scsi_dev_config() to ensure that any error from that function is propagated to libsas. Signed-off-by: Damien Le Moal Reviewed-by: Hannes Reinecke Reviewed-by: John Garry Tested-by: Chia-Lin Kao (AceLan) --- drivers/ata/libata-sata.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c index a701e1538482..83a9497e48e1 100644 --- a/drivers/ata/libata-sata.c +++ b/drivers/ata/libata-sata.c @@ -1182,8 +1182,8 @@ EXPORT_SYMBOL_GPL(ata_sas_tport_delete); int ata_sas_slave_configure(struct scsi_device *sdev, struct ata_port *ap) { ata_scsi_sdev_config(sdev); - ata_scsi_dev_config(sdev, ap->link.device); - return 0; + + return ata_scsi_dev_config(sdev, ap->link.device); } EXPORT_SYMBOL_GPL(ata_sas_slave_configure);