| Message ID | 20231023072957.20191-1-hare@suse.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | pmcraid: add missing scsi_device_put() in pmcraid_eh_target_reset_handler() | expand |
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Hannes, > When breaking out of a shost_for_each_device() loop one need to do an > explicit scsi_device_put(). Applied to 6.7/scsi-staging, thanks!
On Mon, 23 Oct 2023 09:29:57 +0200, Hannes Reinecke wrote: > When breaking out of a shost_for_each_device() loop one need to do > an explicit scsi_device_put(). > > Applied to 6.7/scsi-queue, thanks! [1/1] pmcraid: add missing scsi_device_put() in pmcraid_eh_target_reset_handler() https://git.kernel.org/mkp/scsi/c/0b1b4b04444f
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c index a831b34c08a4..cd19e452c9ee 100644 --- a/drivers/scsi/pmcraid.c +++ b/drivers/scsi/pmcraid.c @@ -3066,6 +3066,7 @@ static int pmcraid_eh_target_reset_handler(struct scsi_cmnd *scmd) { struct Scsi_Host *shost = scmd->device->host; struct scsi_device *scsi_dev = NULL, *tmp; + int ret; shost_for_each_device(tmp, shost) { if ((tmp->channel == scmd->device->channel) && @@ -3078,9 +3079,11 @@ static int pmcraid_eh_target_reset_handler(struct scsi_cmnd *scmd) return FAILED; sdev_printk(KERN_INFO, scsi_dev, "Doing target reset due to an I/O command timeout.\n"); - return pmcraid_reset_device(scsi_dev, - PMCRAID_INTERNAL_TIMEOUT, - RESET_DEVICE_TARGET); + ret = pmcraid_reset_device(scsi_dev, + PMCRAID_INTERNAL_TIMEOUT, + RESET_DEVICE_TARGET); + scsi_device_put(scsi_dev); + return ret; } /**
When breaking out of a shost_for_each_device() loop one need to do an explicit scsi_device_put(). Fixes: c2a14ab3b9b3 ("scsi: pmcraid: Select device in pmcraid_eh_target_reset_handler()") Signed-off-by: Hannes Reinecke <hare@suse.de> --- drivers/scsi/pmcraid.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)