| Message ID | 20240129-ufs-core-reset-fix-v1-1-7ac628aa735f@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | ufs: qcom: Mark "core_reset" as required property | expand |
On Mon, 29 Jan 2024 13:22:04 +0530, Manivannan Sadhasivam wrote: > Apart from the legacy UFS controllers that were not supported in upstream, > rest of the controllers do require reset property to reset the UFS host > controller. So mark them as required. > > Even though this is an ABI break, the bindings should reflect the > capabilities of the hardware. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml index 10c146424baa..03dce5e402d1 100644 --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml @@ -108,6 +108,8 @@ properties: required: - compatible - reg + - resets + - reset-names allOf: - $ref: ufs-common.yaml
Apart from the legacy UFS controllers that were not supported in upstream, rest of the controllers do require reset property to reset the UFS host controller. So mark them as required. Even though this is an ABI break, the bindings should reflect the capabilities of the hardware. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++ 1 file changed, 2 insertions(+)