From patchwork Thu Feb 15 14:39:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maurizio Lombardi X-Patchwork-Id: 13558505 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9240213246C for ; Thu, 15 Feb 2024 14:39:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708008001; cv=none; b=u8n7Ou4YlV+SHfTpHcOw7l/2oLhYTEg+wMLyTPlDsnuIQaJabtr0gYoLgHHyYtRb4VtigKGEJG7E7gc+dmrkTVzYY9LppNebecvhk1xyDpLPcd9rtL3Kc+mQ4vo1MM/w8npEMmbbI7QRNUSIxNuNhCpgBjq35z/ubAL3yf6yAc8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708008001; c=relaxed/simple; bh=pyiETiT0mWRVTFHitcfy6ifRjN7asMxAy4uLZDURMBk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gthdLmjMULsUDDhgrLDIdX977STgiXxz4NqPirug43YOZEvGuyzOR0vc0/W3aTe6e5u8J9sF0MJv9hFpwYeaea5UQHqHqg0c2y6MzDA6euRV/BjhEnFEXqfzFO4YVe223eND3ImDq9tbrmLiI3B6/2mFAkASp+BPgKCD10f2oDk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Y+yHeLbJ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y+yHeLbJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708007997; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EerRsS3pnhmM4qDFUqEJSQKn/OlEoujFDPhFMuqHJ58=; b=Y+yHeLbJdVL0pl2nmfdBV1qkvA0mbjy7vGt1jiX4Nl89mKFS9veMREBDh6Oev0sJc4UsXh ia4HPbhvRhPnp8hPv/kt0B3Ua8zt3Du4hYqR+G0WKahqSW9VUma1lxyyyx/YGIRsZl+tCN UTGt3z/dhUJFH5kBBq1dGOaRfWsmVDs= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-547-xzAAwuTIN4WIZqtE8jyt-Q-1; Thu, 15 Feb 2024 09:39:53 -0500 X-MC-Unique: xzAAwuTIN4WIZqtE8jyt-Q-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A4B2138060E2; Thu, 15 Feb 2024 14:39:52 +0000 (UTC) Received: from kalibr.redhat.com (unknown [10.47.238.145]) by smtp.corp.redhat.com (Postfix) with ESMTP id C7BFC40C106C; Thu, 15 Feb 2024 14:39:50 +0000 (UTC) From: Maurizio Lombardi To: michael.christie@oracle.com Cc: d.bogdanov@yadro.com, target-devel@vger.kernel.org, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, james.bottomley@hansenpartnership.com Subject: [PATCH V2 2/2] target: set the xcopy_wq pointer to NULL after free. Date: Thu, 15 Feb 2024 15:39:44 +0100 Message-Id: <20240215143944.847184-3-mlombard@redhat.com> In-Reply-To: <20240215143944.847184-1-mlombard@redhat.com> References: <20240215143944.847184-1-mlombard@redhat.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 Do not leave a dangling pointer after free. Signed-off-by: Maurizio Lombardi --- drivers/target/target_core_xcopy.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/target/target_core_xcopy.c b/drivers/target/target_core_xcopy.c index 4128631c9dfd..1f79da0041e3 100644 --- a/drivers/target/target_core_xcopy.c +++ b/drivers/target/target_core_xcopy.c @@ -491,8 +491,10 @@ int target_xcopy_setup_pt(void) void target_xcopy_release_pt(void) { - if (xcopy_wq) + if (xcopy_wq) { destroy_workqueue(xcopy_wq); + xcopy_wq = NULL; + } } /*