| Message ID | 20240308114339.1340549-6-john.g.garry@oracle.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f1604214fdc7d449d008751c39d453dd9b52e65a |
| Headers | show |
| Series | Add LIBSAS_SHT_BASE for libsas | expand |
On Fri, Mar 08, 2024 at 11:43:38AM +0000, John Garry wrote: > Use standard template for scsi_host_template structure to reduce > duplication. > > Signed-off-by: John Garry <john.g.garry@oracle.com> > --- > drivers/scsi/mvsas/mv_init.c | 19 +------------------ > 1 file changed, 1 insertion(+), 18 deletions(-) Reviewed-by: Igor Pylypiv <ipylypiv@google.com> Thanks, Igor > > diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c > index 43ebb331e216..fb81d267c9cc 100644 > --- a/drivers/scsi/mvsas/mv_init.c > +++ b/drivers/scsi/mvsas/mv_init.c > @@ -30,28 +30,11 @@ static const struct attribute_group *mvst_host_groups[]; > #define SOC_SAS_NUM 2 > > static const struct scsi_host_template mvs_sht = { > - .module = THIS_MODULE, > - .name = DRV_NAME, > - .queuecommand = sas_queuecommand, > - .dma_need_drain = ata_scsi_dma_need_drain, > - .target_alloc = sas_target_alloc, > - .slave_configure = sas_slave_configure, > + LIBSAS_SHT_BASE > .scan_finished = mvs_scan_finished, > .scan_start = mvs_scan_start, > - .change_queue_depth = sas_change_queue_depth, > - .bios_param = sas_bios_param, > .can_queue = 1, > - .this_id = -1, > .sg_tablesize = SG_ALL, > - .max_sectors = SCSI_DEFAULT_MAX_SECTORS, > - .eh_device_reset_handler = sas_eh_device_reset_handler, > - .eh_target_reset_handler = sas_eh_target_reset_handler, > - .slave_alloc = sas_slave_alloc, > - .target_destroy = sas_target_destroy, > - .ioctl = sas_ioctl, > -#ifdef CONFIG_COMPAT > - .compat_ioctl = sas_ioctl, > -#endif > .shost_groups = mvst_host_groups, > .track_queue_depth = 1, > }; > -- > 2.31.1 >
On 2024/3/8 19:43, John Garry wrote: > Use standard template for scsi_host_template structure to reduce > duplication. > > Signed-off-by: John Garry<john.g.garry@oracle.com> > --- > drivers/scsi/mvsas/mv_init.c | 19 +------------------ > 1 file changed, 1 insertion(+), 18 deletions(-) Reviewed-by: Jason Yan <yanaijie@huawei.com>
diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c index 43ebb331e216..fb81d267c9cc 100644 --- a/drivers/scsi/mvsas/mv_init.c +++ b/drivers/scsi/mvsas/mv_init.c @@ -30,28 +30,11 @@ static const struct attribute_group *mvst_host_groups[]; #define SOC_SAS_NUM 2 static const struct scsi_host_template mvs_sht = { - .module = THIS_MODULE, - .name = DRV_NAME, - .queuecommand = sas_queuecommand, - .dma_need_drain = ata_scsi_dma_need_drain, - .target_alloc = sas_target_alloc, - .slave_configure = sas_slave_configure, + LIBSAS_SHT_BASE .scan_finished = mvs_scan_finished, .scan_start = mvs_scan_start, - .change_queue_depth = sas_change_queue_depth, - .bios_param = sas_bios_param, .can_queue = 1, - .this_id = -1, .sg_tablesize = SG_ALL, - .max_sectors = SCSI_DEFAULT_MAX_SECTORS, - .eh_device_reset_handler = sas_eh_device_reset_handler, - .eh_target_reset_handler = sas_eh_target_reset_handler, - .slave_alloc = sas_slave_alloc, - .target_destroy = sas_target_destroy, - .ioctl = sas_ioctl, -#ifdef CONFIG_COMPAT - .compat_ioctl = sas_ioctl, -#endif .shost_groups = mvst_host_groups, .track_queue_depth = 1, };
Use standard template for scsi_host_template structure to reduce duplication. Signed-off-by: John Garry <john.g.garry@oracle.com> --- drivers/scsi/mvsas/mv_init.c | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-)