| Message ID | 20240627124926.512662-6-hch@lst.de (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/5] loop: don't set QUEUE_FLAG_NOMERGES | expand |
On Thu, Jun 27, 2024 at 2:49 PM Christoph Hellwig <hch@lst.de> wrote: > > QUEUE_FLAG_SAME_FORCE has been set by rnbd-cnt since the initial > merge. There is no good reason for a driver to force exact core > delivery, which is tunable for very specific workloads and not a > driver setting. > > Signed-off-by: Christoph Hellwig <hch@lst.de> en, I think it's fine, we still have the option to set it via block sysfs interface. Acked-by: Jack Wang <jinpu.wang@ionos.com> > --- > drivers/block/rnbd/rnbd-clt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c > index 0e3773fe479706..c34695d2eea7fe 100644 > --- a/drivers/block/rnbd/rnbd-clt.c > +++ b/drivers/block/rnbd/rnbd-clt.c > @@ -1397,7 +1397,6 @@ static int rnbd_client_setup_device(struct rnbd_clt_dev *dev, > dev->queue = dev->gd->queue; > rnbd_init_mq_hw_queues(dev); > > - blk_queue_flag_set(QUEUE_FLAG_SAME_FORCE, dev->queue); > return rnbd_clt_setup_gen_disk(dev, rsp, idx); > } > > -- > 2.43.0 >
diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c index 0e3773fe479706..c34695d2eea7fe 100644 --- a/drivers/block/rnbd/rnbd-clt.c +++ b/drivers/block/rnbd/rnbd-clt.c @@ -1397,7 +1397,6 @@ static int rnbd_client_setup_device(struct rnbd_clt_dev *dev, dev->queue = dev->gd->queue; rnbd_init_mq_hw_queues(dev); - blk_queue_flag_set(QUEUE_FLAG_SAME_FORCE, dev->queue); return rnbd_clt_setup_gen_disk(dev, rsp, idx); }
QUEUE_FLAG_SAME_FORCE has been set by rnbd-cnt since the initial merge. There is no good reason for a driver to force exact core delivery, which is tunable for very specific workloads and not a driver setting. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/block/rnbd/rnbd-clt.c | 1 - 1 file changed, 1 deletion(-)