| Message ID | 20240710171057.35066-9-njavali@marvell.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | qla2xxx misc. bug fixes | expand |
On 7/10/24 10:10 AM, Nilesh Javali wrote: > From: Shreyas Deodhar <sdeodhar@marvell.com> > > Bios version was popluated for FDMI response. Systems with EFI > would show optrom version as 0. > EFI version is populated here and BIOS version is already displayed > under FDMI_HBA_BOOT_BIOS_NAME. > > Cc: stable@vger.kernel.org > Signed-off-by: Shreyas Deodhar<sdeodhar@marvell.com> > Signed-off-by: Nilesh Javali <njavali@marvell.com> > --- > drivers/scsi/qla2xxx/qla_gs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c > index e801cd9e2345..caa9a3cd2580 100644 > --- a/drivers/scsi/qla2xxx/qla_gs.c > +++ b/drivers/scsi/qla2xxx/qla_gs.c > @@ -1710,7 +1710,7 @@ qla2x00_hba_attributes(scsi_qla_host_t *vha, void *entries, > eiter->type = cpu_to_be16(FDMI_HBA_OPTION_ROM_VERSION); > alen = scnprintf( > eiter->a.orom_version, sizeof(eiter->a.orom_version), > - "%d.%02d", ha->bios_revision[1], ha->bios_revision[0]); > + "%d.%02d", ha->efi_revision[1], ha->efi_revision[0]); > alen += FDMI_ATTR_ALIGNMENT(alen); > alen += FDMI_ATTR_TYPELEN(eiter); > eiter->len = cpu_to_be16(alen); Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c index e801cd9e2345..caa9a3cd2580 100644 --- a/drivers/scsi/qla2xxx/qla_gs.c +++ b/drivers/scsi/qla2xxx/qla_gs.c @@ -1710,7 +1710,7 @@ qla2x00_hba_attributes(scsi_qla_host_t *vha, void *entries, eiter->type = cpu_to_be16(FDMI_HBA_OPTION_ROM_VERSION); alen = scnprintf( eiter->a.orom_version, sizeof(eiter->a.orom_version), - "%d.%02d", ha->bios_revision[1], ha->bios_revision[0]); + "%d.%02d", ha->efi_revision[1], ha->efi_revision[0]); alen += FDMI_ATTR_ALIGNMENT(alen); alen += FDMI_ATTR_TYPELEN(eiter); eiter->len = cpu_to_be16(alen);