diff mbox series

[2/2] block: Don't check REQ_ATOMIC for reads

Message ID 20240805113315.1048591-3-john.g.garry@oracle.com (mailing list archive)
State Accepted
Headers show
Series block atomic writes tidy-ups/fix | expand

Commit Message

John Garry Aug. 5, 2024, 11:33 a.m. UTC 
We check in submit_bio_noacct() if flag REQ_ATOMIC is set for both read and
write operations, and then validate the atomic operation if set. Flag
REQ_ATOMIC can only be set for writes, so don't bother checking for reads.

Fixes: 9da3d1e912f3 ("block: Add core atomic write support")
Signed-off-by: John Garry <john.g.garry@oracle.com>
---
 block/blk-core.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Kanchan Joshi Aug. 6, 2024, 12:10 p.m. UTC | #1 
Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
diff mbox series

Patch

diff --git a/block/blk-core.c b/block/blk-core.c
index 1217c2cd66dd..bc5e8c5eaac9 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -799,6 +799,7 @@  void submit_bio_noacct(struct bio *bio)
 
 	switch (bio_op(bio)) {
 	case REQ_OP_READ:
+		break;
 	case REQ_OP_WRITE:
 		if (bio->bi_opf & REQ_ATOMIC) {
 			status = blk_validate_atomic_write_op_size(q, bio);