| Message ID | 20241024084417.154655-1-zengheng4@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | scsi: fusion: Fix not used variable 'rc' | expand |
On Thu, 24 Oct 2024 16:44:17 +0800, Zeng Heng wrote: > Fixing exposed the fact that improperly ignore the return value of > scsi_device_reprobe() in _scsih_reprobe_lun(). Fixing the calling code to > deal with the potential error is non-trivial, so for now just WARN_ON(). > > The handling of scsi_device_reprobe()'s return value refers to > _scsih_reprobe_lun() and the following link: > https://lore.kernel.org/all/094fdbf57487af4f395238c0525b2a560c8f68f0.1469766027.git.calvinowens@fb.com/ > > [...] Applied to 6.13/scsi-queue, thanks! [1/1] scsi: fusion: Fix not used variable 'rc' https://git.kernel.org/mkp/scsi/c/bd65694223f7
diff --git a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c index a0bcb0864ecd..a798e26c6402 100644 --- a/drivers/message/fusion/mptsas.c +++ b/drivers/message/fusion/mptsas.c @@ -4231,10 +4231,8 @@ mptsas_find_phyinfo_by_phys_disk_num(MPT_ADAPTER *ioc, u8 phys_disk_num, static void mptsas_reprobe_lun(struct scsi_device *sdev, void *data) { - int rc; - sdev->no_uld_attach = data ? 1 : 0; - rc = scsi_device_reprobe(sdev); + WARN_ON(scsi_device_reprobe(sdev)); } static void
Fixing exposed the fact that improperly ignore the return value of scsi_device_reprobe() in _scsih_reprobe_lun(). Fixing the calling code to deal with the potential error is non-trivial, so for now just WARN_ON(). The handling of scsi_device_reprobe()'s return value refers to _scsih_reprobe_lun() and the following link: https://lore.kernel.org/all/094fdbf57487af4f395238c0525b2a560c8f68f0.1469766027.git.calvinowens@fb.com/ Fixes: f99be43b3024 ("[SCSI] fusion: power pc and miscellaneous bug fixs") Signed-off-by: Zeng Heng <zengheng4@huawei.com> --- drivers/message/fusion/mptsas.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)