| Message ID | 20241030102715.3312308-2-tudor.ambarus@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] scsi: ufs: exynos: remove empty drv_init method | expand |
On Wed, Oct 30, 2024 at 10:27:15AM +0000, Tudor Ambarus wrote: > The pointer to device can be obtained from ufs->hba->dev, > remove superfluous function parameter. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > drivers/ufs/host/ufs-exynos.c | 4 ++-- > drivers/ufs/host/ufs-exynos.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c > index db89ebe48bcd..7e381ab1011d 100644 > --- a/drivers/ufs/host/ufs-exynos.c > +++ b/drivers/ufs/host/ufs-exynos.c > @@ -198,7 +198,7 @@ static inline void exynos_ufs_ungate_clks(struct exynos_ufs *ufs) > exynos_ufs_ctrl_clkstop(ufs, false); > } > > -static int exynosauto_ufs_drv_init(struct device *dev, struct exynos_ufs *ufs) > +static int exynosauto_ufs_drv_init(struct exynos_ufs *ufs) > { > struct exynos_ufs_uic_attr *attr = ufs->drv_data->uic_attr; > > @@ -1424,7 +1424,7 @@ static int exynos_ufs_init(struct ufs_hba *hba) > exynos_ufs_fmp_init(hba, ufs); > > if (ufs->drv_data->drv_init) { > - ret = ufs->drv_data->drv_init(dev, ufs); > + ret = ufs->drv_data->drv_init(ufs); > if (ret) { > dev_err(dev, "failed to init drv-data\n"); > goto out; > diff --git a/drivers/ufs/host/ufs-exynos.h b/drivers/ufs/host/ufs-exynos.h > index 1646c4a9bb08..9670dc138d1e 100644 > --- a/drivers/ufs/host/ufs-exynos.h > +++ b/drivers/ufs/host/ufs-exynos.h > @@ -182,7 +182,7 @@ struct exynos_ufs_drv_data { > unsigned int quirks; > unsigned int opts; > /* SoC's specific operations */ > - int (*drv_init)(struct device *dev, struct exynos_ufs *ufs); > + int (*drv_init)(struct exynos_ufs *ufs); > int (*pre_link)(struct exynos_ufs *ufs); > int (*post_link)(struct exynos_ufs *ufs); > int (*pre_pwr_change)(struct exynos_ufs *ufs, > -- > 2.47.0.199.ga7371fff76-goog > >
diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index db89ebe48bcd..7e381ab1011d 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -198,7 +198,7 @@ static inline void exynos_ufs_ungate_clks(struct exynos_ufs *ufs) exynos_ufs_ctrl_clkstop(ufs, false); } -static int exynosauto_ufs_drv_init(struct device *dev, struct exynos_ufs *ufs) +static int exynosauto_ufs_drv_init(struct exynos_ufs *ufs) { struct exynos_ufs_uic_attr *attr = ufs->drv_data->uic_attr; @@ -1424,7 +1424,7 @@ static int exynos_ufs_init(struct ufs_hba *hba) exynos_ufs_fmp_init(hba, ufs); if (ufs->drv_data->drv_init) { - ret = ufs->drv_data->drv_init(dev, ufs); + ret = ufs->drv_data->drv_init(ufs); if (ret) { dev_err(dev, "failed to init drv-data\n"); goto out; diff --git a/drivers/ufs/host/ufs-exynos.h b/drivers/ufs/host/ufs-exynos.h index 1646c4a9bb08..9670dc138d1e 100644 --- a/drivers/ufs/host/ufs-exynos.h +++ b/drivers/ufs/host/ufs-exynos.h @@ -182,7 +182,7 @@ struct exynos_ufs_drv_data { unsigned int quirks; unsigned int opts; /* SoC's specific operations */ - int (*drv_init)(struct device *dev, struct exynos_ufs *ufs); + int (*drv_init)(struct exynos_ufs *ufs); int (*pre_link)(struct exynos_ufs *ufs); int (*post_link)(struct exynos_ufs *ufs); int (*pre_pwr_change)(struct exynos_ufs *ufs,
The pointer to device can be obtained from ufs->hba->dev, remove superfluous function parameter. Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> --- drivers/ufs/host/ufs-exynos.c | 4 ++-- drivers/ufs/host/ufs-exynos.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)