| Message ID | 20241031150033.3440894-7-peter.griffin@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | UFS cleanups and enhancements to ufs-exynos for gs101 | expand |
On 10/31/24 3:00 PM, Peter Griffin wrote: > The values calculated in exynos_ufs_specify_phy_time_attr() are only > used in exynos_ufs_config_phy_time_attr() which is only called if the > EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR flag is not set. > > Add a check for this flag to exynos_ufs_specify_phy_time_attr() and > return for platforms that don't set it. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> > --- > v3: update commit message (Tudor) > --- > drivers/ufs/host/ufs-exynos.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c > index 2c2fed691b95..0ac940690a15 100644 > --- a/drivers/ufs/host/ufs-exynos.c > +++ b/drivers/ufs/host/ufs-exynos.c > @@ -541,6 +541,9 @@ static void exynos_ufs_specify_phy_time_attr(struct exynos_ufs *ufs) > struct exynos_ufs_uic_attr *attr = ufs->drv_data->uic_attr; > struct ufs_phy_time_cfg *t_cfg = &ufs->t_cfg; > > + if (ufs->opts & EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR) > + return; > + > t_cfg->tx_linereset_p = > exynos_ufs_calc_time_cntr(ufs, attr->tx_dif_p_nsec); > t_cfg->tx_linereset_n =
diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index 2c2fed691b95..0ac940690a15 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -541,6 +541,9 @@ static void exynos_ufs_specify_phy_time_attr(struct exynos_ufs *ufs) struct exynos_ufs_uic_attr *attr = ufs->drv_data->uic_attr; struct ufs_phy_time_cfg *t_cfg = &ufs->t_cfg; + if (ufs->opts & EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR) + return; + t_cfg->tx_linereset_p = exynos_ufs_calc_time_cntr(ufs, attr->tx_dif_p_nsec); t_cfg->tx_linereset_n =
The values calculated in exynos_ufs_specify_phy_time_attr() are only used in exynos_ufs_config_phy_time_attr() which is only called if the EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR flag is not set. Add a check for this flag to exynos_ufs_specify_phy_time_attr() and return for platforms that don't set it. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- v3: update commit message (Tudor) --- drivers/ufs/host/ufs-exynos.c | 3 +++ 1 file changed, 3 insertions(+)