| Message ID | 20250225161324.184873-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [next] scsi: scsi_debug: Fix addition of uninitialized variable len | expand |
diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index 722ee8c067ae..f3e9a63bbf02 100644 --- a/drivers/scsi/scsi_debug.c +++ b/drivers/scsi/scsi_debug.c @@ -3032,7 +3032,7 @@ static int resp_mode_sense(struct scsi_cmnd *scp, case 0xf: /* Compression Mode Page (tape) */ if (!is_tape) goto bad_pcode; - len += resp_compression_m_pg(ap, pcontrol, target, devip->tape_dce); + len = resp_compression_m_pg(ap, pcontrol, target, devip->tape_dce); offset += len; break; case 0x11: /* Partition Mode Page (tape) */
There is an addition on a previously uninitialized variable len that results in an undefined result. Fix this by making the addition an assignment. Issue detected with static analysis. Fixes: 568354b24c7d ("scsi: scsi_debug: Add compression mode page for tapes") Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/scsi/scsi_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)