[-next] scsi: qedi: fix build, depends on UIO

Commit Message

Randy Dunlap Dec. 20, 2016, 4:43 p.m. UTC

From: Randy Dunlap <[e-mail]>

Fix build of SCSI qedi driver. It uses uio interfaces so it
should depend on UIO.

ERROR: "uio_unregister_device" [drivers/scsi/qedi/qedi.ko] undefined!
ERROR: "uio_event_notify" [drivers/scsi/qedi/qedi.ko] undefined!
ERROR: "__uio_register_device" [drivers/scsi/qedi/qedi.ko] undefined!

Signed-off-by: Randy Dunlap <[e-mail]>
Cc: [e-mail]
---
 drivers/scsi/qedi/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Martin K. Petersen Dec. 20, 2016, 10:49 p.m. UTC | #1

>>>>> "Randy" == Randy Dunlap <[e-mail]> writes:

Randy> From: Randy Dunlap <[e-mail]> Fix build of SCSI qedi
Randy> driver. It uses uio interfaces so it should depend on UIO.

Applied to 4.10/scsi-fixes.

Christoph Hellwig Dec. 21, 2016, 7:35 a.m. UTC | #2

On Tue, Dec 20, 2016 at 08:43:30AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <[e-mail]>
> 
> Fix build of SCSI qedi driver. It uses uio interfaces so it
> should depend on UIO.
> 
> ERROR: "uio_unregister_device" [drivers/scsi/qedi/qedi.ko] undefined!
> ERROR: "uio_event_notify" [drivers/scsi/qedi/qedi.ko] undefined!
> ERROR: "__uio_register_device" [drivers/scsi/qedi/qedi.ko] undefined!

Why is it hiding an uio driver in an iscsi offload driver?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- linux-next-20161220.orig/drivers/scsi/qedi/Kconfig
+++ linux-next-20161220/drivers/scsi/qedi/Kconfig
@@ -1,6 +1,6 @@ 
 config QEDI
 	tristate "QLogic QEDI 25/40/100Gb iSCSI Initiator Driver Support"
-	depends on PCI && SCSI
+	depends on PCI && SCSI && UIO
 	depends on QED
 	select SCSI_ISCSI_ATTRS
 	select QED_LL2