From patchwork Tue Oct 31 17:36:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Saxena X-Patchwork-Id: 10035019 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 89978600C5 for ; Tue, 31 Oct 2017 17:36:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 73AB228B59 for ; Tue, 31 Oct 2017 17:36:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6543528B72; Tue, 31 Oct 2017 17:36:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 19E0628B59 for ; Tue, 31 Oct 2017 17:36:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753896AbdJaRgW (ORCPT ); Tue, 31 Oct 2017 13:36:22 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:51323 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753872AbdJaRgU (ORCPT ); Tue, 31 Oct 2017 13:36:20 -0400 Received: by mail-oi0-f68.google.com with SMTP id j126so27879893oib.8 for ; Tue, 31 Oct 2017 10:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=zsvipP3KzGnvWGsr7xmZhwqhLUJ+D8l+vV9nCRXkTkI=; b=hZEsQC+4WKFI33yRWUmPYGyhSxhhKfLr7z1E11o4HlDZrW1ESD9Uv21TkijmMaQVxz 26cGio1ooZMHqlv/g00TtiAWee9RMYUPPzpfqXqcPItqtZ64foNOoM1ciq6vzbWp7/K6 cmcjmpniHKA3GK999uZ1AuR8l0Gac/PykAoKY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=zsvipP3KzGnvWGsr7xmZhwqhLUJ+D8l+vV9nCRXkTkI=; b=bEQcSqzsJkuxrPv/4wD9lFvz9CuKNLgZexumBzbhdVY5hQiv+Y4qE6oGBpo7ZFIIV6 Ov+E0wTsSPa3R+l4mGPxG6dQVqJrfUTIwVo1b5p9DM/ak2jedhOAiO067ZINRkhqQeM2 /qmmNGHDJEiJvsTesSwvMb8SZBWw2/yuK7ZoH/qPyTuzEMG9ko6jYQhlbwC5JYIbseOy kOzKbSEwUi8pRQU0IPebEF9dl0elJA3lC7So6hp53clTBkX7j/UgZdKsZZguCXZDySlz xZzINeD91Hm374dKiQKb0+dK+2PI9pLtEWkiPFMT5ETDngjWsIh2XjxcOHqEMlheDpRu jgOg== X-Gm-Message-State: AMCzsaUDYnEIW303Cl5wGnW4TrTwIKNjDQJuilmjD4QwJ10NOO332q0w 3FuyO+CAwDchvd9dOCSFeJcQjkJwc1i3F2NXzrQx+w== X-Google-Smtp-Source: ABhQp+S2TNNEw2WnpMdbz+AihETOtniE2dGQSy+FEyr+VbPt6LMw2CqBy1INeIhrwSIc9hrHALhoc7fpP/hQXeTc5fU= X-Received: by 10.157.68.114 with SMTP id f47mr1571208otj.282.1509471379746; Tue, 31 Oct 2017 10:36:19 -0700 (PDT) From: Sumit Saxena References: <1508925428-51660-1-git-send-email-xieyisheng1@huawei.com> In-Reply-To: <1508925428-51660-1-git-send-email-xieyisheng1@huawei.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQHIDvQyF6gY9bI2hKyfpWtJaINO4qMUvzPA Date: Tue, 31 Oct 2017 23:06:18 +0530 Message-ID: <5501933ac4d2773c529357265e4b2c73@mail.gmail.com> Subject: RE: [PATCH 1/2] scsi: megaraid: Remove redundant code in megasas_alloc_cmds To: Yisheng Xie , Kashyap Desai , Shivasharan Srikanteshwara , jejb@linux.vnet.ibm.com, martin.petersen@oracle.com Cc: "PDL,MEGARAIDLINUX" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP -----Original Message----- From: Yisheng Xie [mailto:xieyisheng1@huawei.com] Sent: Wednesday, October 25, 2017 3:27 PM To: kashyap.desai@broadcom.com; sumit.saxena@broadcom.com; shivasharan.srikanteshwara@broadcom.com; jejb@linux.vnet.ibm.com; martin.petersen@oracle.com Cc: megaraidlinux.pdl@broadcom.com; linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Yisheng Xie Subject: [PATCH 1/2] scsi: megaraid: Remove redundant code in megasas_alloc_cmds megasas_alloc_cmds is to alloc cmd_list of instance instead of fusion, and fusion is useless in this function. Just remove it. Signed-off-by: Yisheng Xie --- drivers/scsi/megaraid/megaraid_sas_base.c | 2 -- 1 file changed, 2 deletions(-) /* Acked-by: Sumit Saxena -- 1.7.12.4 diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index e518dad..0640168 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -4033,9 +4033,7 @@ int megasas_alloc_cmds(struct megasas_instance *instance) int j; u16 max_cmd; struct megasas_cmd *cmd; - struct fusion_context *fusion; - fusion = instance->ctrl_context; max_cmd = instance->max_mfi_cmds;