From patchwork Tue Apr 7 12:33:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 6169721 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 158BE9F2EC for ; Tue, 7 Apr 2015 12:34:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A382F20357 for ; Tue, 7 Apr 2015 12:34:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED4EB2034A for ; Tue, 7 Apr 2015 12:34:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753191AbbDGMeC (ORCPT ); Tue, 7 Apr 2015 08:34:02 -0400 Received: from mail-bl2on0058.outbound.protection.outlook.com ([65.55.169.58]:60002 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751528AbbDGMeA (ORCPT ); Tue, 7 Apr 2015 08:34:00 -0400 Received: from BY2PR02CA0036.namprd02.prod.outlook.com (10.141.216.26) by DM2PR0201MB0976.namprd02.prod.outlook.com (25.160.217.139) with Microsoft SMTP Server (TLS) id 15.1.130.23; Tue, 7 Apr 2015 12:33:57 +0000 Received: from BY2FFO11FD031.protection.gbl (2a01:111:f400:7c0c::194) by BY2PR02CA0036.outlook.office365.com (2a01:111:e400:2c40::26) with Microsoft SMTP Server (TLS) id 15.1.130.23 via Frontend Transport; Tue, 7 Apr 2015 12:33:57 +0000 Authentication-Results: spf=pass (sender IP is 63.163.107.173) smtp.mailfrom=sandisk.com; lst.de; dkim=none (message not signed) header.d=none; Received-SPF: Pass (protection.outlook.com: domain of sandisk.com designates 63.163.107.173 as permitted sender) receiver=protection.outlook.com; client-ip=63.163.107.173; helo=milsmgep12.sandisk.com; Received: from milsmgep12.sandisk.com (63.163.107.173) by BY2FFO11FD031.mail.protection.outlook.com (10.1.14.196) with Microsoft SMTP Server id 15.1.136.16 via Frontend Transport; Tue, 7 Apr 2015 12:33:55 +0000 Received: from MILHUBIP04.sdcorp.global.sandisk.com ( [172.22.12.162]) by milsmgep12.sandisk.com (Symantec Messaging Gateway) with SMTP id 22.A5.14695.3BEC3255; Tue, 7 Apr 2015 05:33:55 -0700 (PDT) Received: from milsmgip11.sandisk.com (10.177.8.100) by MILHUBIP04.sdcorp.global.sandisk.com (10.177.9.97) with Microsoft SMTP Server id 14.3.224.2; Tue, 7 Apr 2015 05:33:55 -0700 X-AuditID: ac160a69-f79656d000003967-d0-5523ceb3e927 Received: from [10.50.231.50] ( [10.177.8.100]) by milsmgip11.sandisk.com (Symantec Messaging Gateway) with SMTP id 8E.A3.19112.1BEC3255; Tue, 7 Apr 2015 05:33:55 -0700 (PDT) Message-ID: <5523CEB0.2020101@sandisk.com> Date: Tue, 7 Apr 2015 14:33:52 +0200 From: Bart Van Assche User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: James Bottomley CC: Christoph Hellwig , "Nicholas A. Bellinger" , Hannes Reinecke , Mike Christie , "linux-scsi@vger.kernel.org" , target-devel Subject: [PATCH v3 3/4] target: Correct a comment References: <5523CE55.3090401@sandisk.com> In-Reply-To: <5523CE55.3090401@sandisk.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAIsWRmVeSWpSXmKPExsWyRoxnke7mc8qhBsdWKlnsWTSJyWLl6qNM Fv/X32ax6L6+g81ixZtuRou21WcYLVqXvmVyYPe4+msVs8f97UeYPHbfbGDzOPzjB7PH5tPV Hp83yQWwRXHZpKTmZJalFunbJXBl7Jh0mrFgJU/F7XMv2RoYJ3J1MXJySAiYSLxsn8wIYYtJ XLi3nq2LkYtDSOAEo8Spew+ZQBJCAtsZJc68ioZpuHDrFwtE0WZGiaMXDrB2MXJw8ApoSex7 GAxSwyKgIvFp6VywoWwCRhLf3s9kAbFFBcIkZq+7CBbnFRCUODnzCVhcREBT4srSuUwgM5kF WpkkVl75CVYkLGAosenofjaII7Qk/n6fzApicwpoS5zZuYkdZC8zUPP6XfogYWYBeYntb+cw g8yREHjIKnFn3h12iF51iZNL5jNNYBSZhWT3LIT2WUjaFzAyr2IUy83MKc5NTy0wNNIrTsxL ySzO1kvOz93ECI4nrswdjCsmmR9iFOBgVOLhZZBTDhViTSwrrsw9xCjBwawkwit7GijEm5JY WZValB9fVJqTWnyIUZqDRUmcV3B6lr+QQHpiSWp2ampBahFMlomDU6qBUVn31K35RxQnHhSc GLO81LM63CR96WqJzdWX1yRtv6Dy8QPz0v6oeQwi4l03L+2Ueto2m120sP/W9qPn+3Q+aR5b +vGt0oSklIpAK76kzxYXLpd+5ZNNMaj6xdDXu1DEuNfL5A6PpP2q7Z8a6+46/i07YXNE73ur 5rnPYjdNV8hVn/v26fEZBiWW4oxEQy3mouJEAKa2fYCjAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgluLIzCtJLcpLzFFi42Lh2siRorv5nHKowYbjYhZ7Fk1isli5+iiT xf/1t1ksuq/vYLNY8aab0aJt9RlGi9alb5kc2D2u/lrF7HF/+xEmj903G9g8Dv/4weyx+XS1 x+dNcgFsUVw2Kak5mWWpRfp2CVwZOyadZixYyVNx+9xLtgbGiVxdjJwcEgImEhdu/WKBsMUk Ltxbz9bFyMUhJLCRUWLnrEVADgcHr4CWxL6HwSA1LAKqEoee/AWrZxMwkvj2fiaYLSoQJjF7 3UVGEJtXQFDi5MwnYHERAU2JK0vnMoHMZBboZJJo3PyHGSQhLGAosenofjYQWwho/t/vk1lB bE4BbYkzOzexg9jMAuoSf+ZdYoaw5SW2v53DPIGRfxaSHbOQlM1CUraAkXkVo1huZk5xbnpm gaGhXnFiXkpmcbZecn7uJkZwWHNG7mB8OtH8ECMTB6dUA6PuXKNA7xd1OtdOvdyv3/10V/CW 3oaTVczKog57ZwffV2PTYMr5q1Kz8dC7PNXeY7apMjsU7n47rSj4Vc3VcKLLveLTh/f9/paW epbhjEVrWfdEifTfvs8dS6d+VVR9GWZbxW1V73nQZP2uTf/vmtz551wdzr/n3XXVt2JWSSEn jDYzyj10dldiKc5INNRiLipOBABW7Cf5GwIAAA== X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:63.163.107.173; CTRY:US; IPV:NLI; EFV:NLI; BMV:1; SFV:NSPM; SFS:(10009020)(6009001)(438002)(189002)(199003)(54356999)(23676002)(87266999)(19580405001)(2950100001)(65816999)(46102003)(76176999)(59896002)(83506001)(19580395003)(50986999)(106466001)(92566002)(33656002)(36756003)(77096005)(110136001)(77156002)(229853001)(62966003)(86362001)(47776003)(65956001)(50466002)(87936001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR0201MB0976; H:milsmgep12.sandisk.com; FPR:; SPF:Pass; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0201MB0976; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5002010)(5005006); SRVR:DM2PR0201MB0976; BCL:0; PCL:0; RULEID:; SRVR:DM2PR0201MB0976; X-Forefront-PRVS: 0539EEBD11 X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2015 12:33:55.6947 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d; Ip=[63.163.107.173]; Helo=[milsmgep12.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0201MB0976 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Correct the comment above the definition of TCM_MAX_COMMAND_SIZE. A quote from Christoph: There aren't any legacy issues, we just decided to handle > 16 byte CDBs in the slow path. Signed-off-by: Bart Van Assche Cc: Nicholas Bellinger Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Mike Christie --- include/target/target_core_base.h | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h index 672150b..7a6e55f 100644 --- a/include/target/target_core_base.h +++ b/include/target/target_core_base.h @@ -17,16 +17,8 @@ /* Don't raise above 511 or REPORT_LUNS needs to handle >1 page */ #define TRANSPORT_MAX_LUNS_PER_TPG 256 /* - * By default we use 32-byte CDBs in TCM Core and subsystem plugin code. - * - * Note that both include/scsi/scsi_cmnd.h:MAX_COMMAND_SIZE and - * include/linux/blkdev.h:BLOCK_MAX_CDB as of v2.6.36-rc4 still use - * 16-byte CDBs by default and require an extra allocation for - * 32-byte CDBs to because of legacy issues. - * - * Within TCM Core there are no such legacy limitiations, so we go ahead - * use 32-byte CDBs by default and use include/scsi/scsi.h:scsi_command_size() - * within all TCM Core and subsystem plugin code. + * Maximum size of a CDB that can be stored in se_cmd without allocating + * memory dynamically for the CDB. */ #define TCM_MAX_COMMAND_SIZE 32 /*