From patchwork Fri May 22 14:42:40 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Smart X-Patchwork-Id: 6465191 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 5C03CC0020 for ; Fri, 22 May 2015 14:43:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8233520483 for ; Fri, 22 May 2015 14:42:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 974A420458 for ; Fri, 22 May 2015 14:42:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757153AbbEVOmx (ORCPT ); Fri, 22 May 2015 10:42:53 -0400 Received: from mail-qg0-f49.google.com ([209.85.192.49]:36578 "EHLO mail-qg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757176AbbEVOmw (ORCPT ); Fri, 22 May 2015 10:42:52 -0400 Received: by qget53 with SMTP id t53so9036299qge.3 for ; Fri, 22 May 2015 07:42:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:user-agent :mime-version:content-type:content-transfer-encoding; bh=Rq3BeDG0OokyjeXtGcF+Qxv+oPXuUL99fhPyS1XBXwc=; b=NMKTBnX3ipy/AmOnrGsMOWOhR6KXliY4jTXEepgE7W70LRuYCQ5ht+28D6iH95+Gla 00Xo2XGUHim2oJ646K2IBU3URaKtslLNT64XGwoMNzGvoDoWcRgALWpoXbhWFp5bABPv 8/MKxMYXgT8kl8jh5KwfrHHkryq+n267QH3A2ToJ/WAql1ZVeoiiT7hXFMoJfV2nzzec do0i5iMUOrf416kIZapfFAR6UG0zbvPtuOdH1ircsG/bXNi/cMZ2bM2aaxT2noDZI8Rf VIDQKpjKEco3uVnBRETeLf3DBYZrJk4mEJ9IWkUjbE3kadckFZOoeKKvonmdhfnPjEou 8UqA== X-Gm-Message-State: ALoCoQky6bUgTDL5thwa/plOflVMaDfLjCIIdvTKgOPyfrvLQOtifuTnR1nG0zqIPo2Gklh43U4f X-Received: by 10.55.21.17 with SMTP id f17mr18801316qkh.41.1432305771785; Fri, 22 May 2015 07:42:51 -0700 (PDT) Received: from myfc17 (c-75-67-235-135.hsd1.nh.comcast.net. [75.67.235.135]) by mx.google.com with ESMTPSA id r31sm1405382qkr.42.2015.05.22.07.42.51 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 22 May 2015 07:42:51 -0700 (PDT) Date: Fri, 22 May 2015 10:42:40 -0400 From: james.smart@avagotech.com (James Smart) To: linux-scsi@vger.kernel.org Subject: [PATCH 6/9] lpfc: Fix cq_id masking problem. Message-ID: <555f4060.Uu2ZGqqAXkqDGUog%james.smart@avagotech.com> User-Agent: Heirloom mailx 12.5 7/5/10 MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fix cq_id masking problem. The driver inadvertainly constrained the id space to 8 bits, when its a full 16 bits from hw. This resulted in bad id's being written to the hardware. Resulted in symptoms such as incomplete initialization, no detection of link events, etc. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Hannes Reinecke --- drivers/scsi/lpfc/lpfc_hw4.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hw4.h b/drivers/scsi/lpfc/lpfc_hw4.h index b94fa46..33ec4fa 100644 --- a/drivers/scsi/lpfc/lpfc_hw4.h +++ b/drivers/scsi/lpfc/lpfc_hw4.h @@ -291,7 +291,7 @@ struct sli4_bls_rsp { struct lpfc_eqe { uint32_t word0; #define lpfc_eqe_resource_id_SHIFT 16 -#define lpfc_eqe_resource_id_MASK 0x000000FF +#define lpfc_eqe_resource_id_MASK 0x0000FFFF #define lpfc_eqe_resource_id_WORD word0 #define lpfc_eqe_minor_code_SHIFT 4 #define lpfc_eqe_minor_code_MASK 0x00000FFF