| Message ID | 55e4bd89.wnXoOtgVrknAjUqh%james.smart@avagotech.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
James Smart wrote: > > From: Firo Yang <firogm@gmail.com> > > kzalloc() returns a void pointer - no need to cast it in > drivers/scsi/lpfc/lpfc_init.c::lpfc_sli_driver_resource_setup() > > Signed-off-by: Firo Yang <firogm@gmail.com> > Signed-off-by: James Smart <james.smart@avagotech.com> > --- > drivers/scsi/lpfc/lpfc_init.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c > index 1992e74..da9b6fc 100644 > --- a/drivers/scsi/lpfc/lpfc_init.c > +++ b/drivers/scsi/lpfc/lpfc_init.c > @@ -4982,8 +4982,7 @@ lpfc_sli_driver_resource_setup(struct lpfc_hba *phba) > } > > if (!phba->sli.ring) > - phba->sli.ring = (struct lpfc_sli_ring *) > - kzalloc(LPFC_SLI3_MAX_RING * > + phba->sli.ring = kzalloc(LPFC_SLI3_MAX_RING * > sizeof(struct lpfc_sli_ring), GFP_KERNEL); > if (!phba->sli.ring) > return -ENOMEM; Reviewed-by: Sebastian Herbszt <herbszt@gmx.de> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/31/2015 10:48 PM, James Smart wrote: > > From: Firo Yang <firogm@gmail.com> > > kzalloc() returns a void pointer - no need to cast it in > drivers/scsi/lpfc/lpfc_init.c::lpfc_sli_driver_resource_setup() > > Signed-off-by: Firo Yang <firogm@gmail.com> > Signed-off-by: James Smart <james.smart@avagotech.com> > --- > drivers/scsi/lpfc/lpfc_init.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c > index 1992e74..da9b6fc 100644 > --- a/drivers/scsi/lpfc/lpfc_init.c > +++ b/drivers/scsi/lpfc/lpfc_init.c > @@ -4982,8 +4982,7 @@ lpfc_sli_driver_resource_setup(struct lpfc_hba *phba) > } > > if (!phba->sli.ring) > - phba->sli.ring = (struct lpfc_sli_ring *) > - kzalloc(LPFC_SLI3_MAX_RING * > + phba->sli.ring = kzalloc(LPFC_SLI3_MAX_RING * > sizeof(struct lpfc_sli_ring), GFP_KERNEL); > if (!phba->sli.ring) > return -ENOMEM; > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 1992e74..da9b6fc 100644 --- a/drivers/scsi/lpfc/lpfc_init.c +++ b/drivers/scsi/lpfc/lpfc_init.c @@ -4982,8 +4982,7 @@ lpfc_sli_driver_resource_setup(struct lpfc_hba *phba) } if (!phba->sli.ring) - phba->sli.ring = (struct lpfc_sli_ring *) - kzalloc(LPFC_SLI3_MAX_RING * + phba->sli.ring = kzalloc(LPFC_SLI3_MAX_RING * sizeof(struct lpfc_sli_ring), GFP_KERNEL); if (!phba->sli.ring) return -ENOMEM;