diff mbox

VMW_PVSCSI: Change to update maintainer details (name, email)

Message ID 57634CBD.8000402@vmware.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Jim Gill June 17, 2016, 1:05 a.m. UTC 
From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001
From: Jim Gill <jgill@vmware.com>
Date: Thu, 16 Jun 2016 14:10:43 -0700
Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

Signed-off-by: Jim Gill <jgill@vmware.com>
---
  drivers/scsi/vmw_pvscsi.c | 2 +-
  drivers/scsi/vmw_pvscsi.h | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Julian Calaby June 17, 2016, 1:48 a.m. UTC | #1 
Hi Jim,

On Fri, Jun 17, 2016 at 11:05 AM, Jim Gill <jgill@vmware.com> wrote:
> From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001
> From: Jim Gill <jgill@vmware.com>
> Date: Thu, 16 Jun 2016 14:10:43 -0700
> Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,
> email)
>
> Signed-off-by: Jim Gill <jgill@vmware.com>
> ---
>  drivers/scsi/vmw_pvscsi.c | 2 +-
>  drivers/scsi/vmw_pvscsi.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
> index 6164634..4a0d3cd 100644
> --- a/drivers/scsi/vmw_pvscsi.c
> +++ b/drivers/scsi/vmw_pvscsi.c
> @@ -17,7 +17,7 @@
>   * along with this program; if not, write to the Free Software
>   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301
> USA.
>   *
> - * Maintained by: Arvind Kumar <arvindkumar@vmware.com>
> + * Maintained by: Jim Gill <jgill@vmware.com>

Shouldn't you update MAINTAINERs too? And isn't having this
information in these files redundant?

Thanks,
Arvind Kumar June 17, 2016, 2:03 a.m. UTC | #2 
Hi Julian,

Thanks for spotting that. We will update that too.

I don't really see it as redundant rather as a quick reference instead of digging out the MAINTAINERS file and then search for vmw_pvscsi.c file. Specially for those readers who might not even know about the MAINTAINERS file.

Thanks!
Arvind
Julian Calaby June 17, 2016, 2:18 a.m. UTC | #3 
Hi Arvind,

On Fri, Jun 17, 2016 at 12:03 PM, Arvind Kumar <arvindkumar@vmware.com> wrote:
> Hi Julian,
>
> Thanks for spotting that. We will update that too.
>
> I don't really see it as redundant rather as a quick reference instead of digging out the MAINTAINERS file and then search for vmw_pvscsi.c file. Specially for those readers who might not even know about the MAINTAINERS file.

You can use the get_maintainers script in the scripts directory to
quickly get information from MAINTAINERS, i.e.:

./scripts/get_maintainers.pl -f drivers/scsi/vmw_pvscsi.c

or

./scripts/get_maintainers.pl patchfile.patch

Thanks,

Julian Calaby


>
> Thanks!
> Arvind
> ________________________________________
> From: Julian Calaby <julian.calaby@gmail.com>
> Sent: Thursday, June 16, 2016 6:48 PM
> To: Jim Gill
> Cc: jejb@linux.vnet.ibm.com; Martin K. Petersen; Arvind Kumar; pv-drivers@vmware.com; linux-scsi; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)
>
> Hi Jim,
>
> On Fri, Jun 17, 2016 at 11:05 AM, Jim Gill <jgill@vmware.com> wrote:
>> From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001
>> From: Jim Gill <jgill@vmware.com>
>> Date: Thu, 16 Jun 2016 14:10:43 -0700
>> Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,
>> email)
>>
>> Signed-off-by: Jim Gill <jgill@vmware.com>
>> ---
>>  drivers/scsi/vmw_pvscsi.c | 2 +-
>>  drivers/scsi/vmw_pvscsi.h | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
>> index 6164634..4a0d3cd 100644
>> --- a/drivers/scsi/vmw_pvscsi.c
>> +++ b/drivers/scsi/vmw_pvscsi.c
>> @@ -17,7 +17,7 @@
>>   * along with this program; if not, write to the Free Software
>>   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301
>> USA.
>>   *
>> - * Maintained by: Arvind Kumar <arvindkumar@vmware.com>
>> + * Maintained by: Jim Gill <jgill@vmware.com>
>
> Shouldn't you update MAINTAINERs too? And isn't having this
> information in these files redundant?
>
> Thanks,
>
> --
> Julian Calaby
>
> Email: julian.calaby@gmail.com
> Profile: https://urldefense.proofpoint.com/v2/url?u=http-3A__www.google.com_profiles_julian.calaby_&d=CwIBaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=bUMaNc7nC9xbXtaMJrOvIIPNpPH0chY2kdRsskQn6GY&m=JibRIMgSBQLffjc5PofQnpJ0k_gawmvafvIKpsEaMzk&s=CeVpY1FwvY9Qlb0VDeQUXeeL3kuVkcIKTZIC7exS6SM&e=
Joe Perches June 17, 2016, 2:33 a.m. UTC | #4 
On Fri, 2016-06-17 at 12:18 +1000, Julian Calaby wrote:
> ./scripts/get_maintainers.pl -f drivers/scsi/vmw_pvscsi.c

just fyi:  the script name is not plural

$ ./scripts/get_maintainer.pl  -f drivers/scsi/vmw_pvscsi.c
Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver)
VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver)
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM)
"Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM)
linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
linux-kernel@vger.kernel.org (open list)

and another fyi:

get_maintainer.pl also has a rarely used "--file-emails" option to
scan for what appears to be email addresses in specific files.

$ ./scripts/get_maintainer.pl  -f --file-emails drivers/scsi/vmw_pvscsi.c
Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver,in file)
VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver)
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM)
"Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM)
linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
linux-kernel@vger.kernel.org (open list)

note the "in file" after Arvind's name
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Julian Calaby June 17, 2016, 2:44 a.m. UTC | #5 
Hi Joe,

On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <joe@perches.com> wrote:
> On Fri, 2016-06-17 at 12:18 +1000, Julian Calaby wrote:
>> ./scripts/get_maintainers.pl -f drivers/scsi/vmw_pvscsi.c
>
> just fyi:  the script name is not plural

Thanks, must have typo'd it between running it and typing it into the email.

> $ ./scripts/get_maintainer.pl  -f drivers/scsi/vmw_pvscsi.c
> Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver)
> VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver)
> "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM)
> "Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM)
> linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
> linux-kernel@vger.kernel.org (open list)
>
> and another fyi:
>
> get_maintainer.pl also has a rarely used "--file-emails" option to
> scan for what appears to be email addresses in specific files.
>
> $ ./scripts/get_maintainer.pl  -f --file-emails drivers/scsi/vmw_pvscsi.c
> Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver,in file)
> VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver)
> "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM)
> "Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM)
> linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
> linux-kernel@vger.kernel.org (open list)
>
> note the "in file" after Arvind's name

Didn't know this, however my point stands: the maintainer line in the
file is redundant if we find maintainers through MAINTAINERS or the
get_maintainer.pl script.

Thanks,
Joe Perches June 17, 2016, 3:04 a.m. UTC | #6 
On Fri, 2016-06-17 at 12:44 +1000, Julian Calaby wrote:
> Hi Joe,

rehi Julian.

> On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <joe@perches.com> wrote:
[]
> > get_maintainer.pl also has a rarely used "--file-emails" option to
> > scan for what appears to be email addresses in specific files.
> > 
> > $ ./scripts/get_maintainer.pl  -f --file-emails drivers/scsi/vmw_pvscsi.c
> > Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver,in file)
> > VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver)
> > "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM)
> > "Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM)
> > linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
> > linux-kernel@vger.kernel.org (open list)
> > 
> > note the "in file" after Arvind's name
> Didn't know this, however my point stands: the maintainer line in the
> file is redundant if we find maintainers through MAINTAINERS or the
> get_maintainer.pl script.

Yes, I'm not suggesting anything else.  Jim's name
should appear in the MAINTAINERS file somewhere.

The question to me is whether or not Jim Gill is
taking over the maintainership of the entire
VMware PVSCSI driver or just a few files of it.

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Julian Calaby June 17, 2016, 3:11 a.m. UTC | #7 
Hi Joe,

On Fri, Jun 17, 2016 at 1:04 PM, Joe Perches <joe@perches.com> wrote:
> On Fri, 2016-06-17 at 12:44 +1000, Julian Calaby wrote:
>> Hi Joe,
>
> rehi Julian.

(I always put a salutation on my emails and always finish them with
"Thanks," =) )

>> On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <joe@perches.com> wrote:
> []
>> > get_maintainer.pl also has a rarely used "--file-emails" option to
>> > scan for what appears to be email addresses in specific files.
>> >
>> > $ ./scripts/get_maintainer.pl  -f --file-emails drivers/scsi/vmw_pvscsi.c
>> > Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver,in file)
>> > VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver)
>> > "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM)
>> > "Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM)
>> > linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
>> > linux-kernel@vger.kernel.org (open list)
>> >
>> > note the "in file" after Arvind's name
>> Didn't know this, however my point stands: the maintainer line in the
>> file is redundant if we find maintainers through MAINTAINERS or the
>> get_maintainer.pl script.
>
> Yes, I'm not suggesting anything else.  Jim's name
> should appear in the MAINTAINERS file somewhere.
>
> The question to me is whether or not Jim Gill is
> taking over the maintainership of the entire
> VMware PVSCSI driver or just a few files of it.

As I see it, he's taking over maintainership of all of it: it's only
files are drivers/scsi/vmw_pvscsi.[ch] AFAIK.

Thanks,
Thomas Hellstrom June 17, 2016, 7:55 a.m. UTC | #8 
Hi!

IMO we shouldn't have maintainer info mentioned in the source files,
since the information is redundant and moreover if we change maintainer
a patch touching multiple files would just look odd, and we'd leave a
lot of stale info in older kernels.

Having the linux git *master* MAINTAINERS file as the authoritative
information source for this makes most sense. If there are different
maintainers of different parts of a single module we should be able to
sort that out internally.

Thanks,
Thomas



On 06/17/2016 05:11 AM, Julian Calaby wrote:
> Hi Joe,
>
> On Fri, Jun 17, 2016 at 1:04 PM, Joe Perches <joe@perches.com> wrote:
>> On Fri, 2016-06-17 at 12:44 +1000, Julian Calaby wrote:
>>> Hi Joe,
>> rehi Julian.
> (I always put a salutation on my emails and always finish them with
> "Thanks," =) )
>
>>> On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <joe@perches.com> wrote:
>> []
>>>> get_maintainer.pl also has a rarely used "--file-emails" option to
>>>> scan for what appears to be email addresses in specific files.
>>>>
>>>> $ ./scripts/get_maintainer.pl  -f --file-emails drivers/scsi/vmw_pvscsi.c
>>>> Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver,in file)
>>>> VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver)
>>>> "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM)
>>>> "Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM)
>>>> linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
>>>> linux-kernel@vger.kernel.org (open list)
>>>>
>>>> note the "in file" after Arvind's name
>>> Didn't know this, however my point stands: the maintainer line in the
>>> file is redundant if we find maintainers through MAINTAINERS or the
>>> get_maintainer.pl script.
>> Yes, I'm not suggesting anything else.  Jim's name
>> should appear in the MAINTAINERS file somewhere.
>>
>> The question to me is whether or not Jim Gill is
>> taking over the maintainership of the entire
>> VMware PVSCSI driver or just a few files of it.
> As I see it, he's taking over maintainership of all of it: it's only
> files are drivers/scsi/vmw_pvscsi.[ch] AFAIK.
>
> Thanks,
>


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jim Gill June 17, 2016, 5:44 p.m. UTC | #9 
On 6/16/16, 8:11 PM, "Julian Calaby" <julian.calaby@gmail.com> wrote:



>[]

>

>>>On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <joe@perches.com> wrote:

>> []

>>The question to me is whether or not Jim Gill is

>> taking over the maintainership of the entire

>> VMware PVSCSI driver or just a few files of it.

>

>As I see it, he's taking over maintainership of all of it: it's only

>files are drivers/scsi/vmw_pvscsi.[ch] AFAIK.


This is correct, I am taking over maintainership of the entire vmw_pvscsi driver.
Martin K. Petersen June 21, 2016, 2:01 a.m. UTC | #10 
>>>>> "Jim" == Jim Gill <jgill@vmware.com> writes:

Updated MAINTAINERS accordingly and applied to 4.8/scsi-queue.
diff mbox

Patch

diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
index 6164634..4a0d3cd 100644
--- a/drivers/scsi/vmw_pvscsi.c
+++ b/drivers/scsi/vmw_pvscsi.c
@@ -17,7 +17,7 @@ 
   * along with this program; if not, write to the Free Software
   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
   *
- * Maintained by: Arvind Kumar <arvindkumar@vmware.com>
+ * Maintained by: Jim Gill <jgill@vmware.com>
   *
   */
  
diff --git a/drivers/scsi/vmw_pvscsi.h b/drivers/scsi/vmw_pvscsi.h
index 12712c9..c097d2c 100644
--- a/drivers/scsi/vmw_pvscsi.h
+++ b/drivers/scsi/vmw_pvscsi.h
@@ -17,7 +17,7 @@ 
   * along with this program; if not, write to the Free Software
   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
   *
- * Maintained by: Arvind Kumar <arvindkumar@vmware.com>
+ * Maintained by: Jim Gill <jgill@vmware.com>
   *
   */