| Message ID | 577accda.46c0620a.65070.ffffec86@mx.google.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On 07/04/2016 11:53 PM, tom.ty89@gmail.com wrote: > From: Tom Yan <tom.ty89@gmail.com> > > It does not make sense and is confusing to response with "Invalid Respond here and in the subject. > field in cbd" while we have no support at all implemented for > FORMAT UNIT. It is decent to let it go to the default, which > will response with "Invalid command operation code" instead. > > Signed-off-by: Tom Yan <tom.ty89@gmail.com> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/05/2016 12:27 AM, Sergei Shtylyov wrote: >> From: Tom Yan <tom.ty89@gmail.com> >> >> It does not make sense and is confusing to response with "Invalid > > Respond here and in the subject. > >> field in cbd" while we have no support at all implemented for CDB. >> FORMAT UNIT. It is decent to let it go to the default, which >> will response with "Invalid command operation code" instead. >> Respond again. >> Signed-off-by: Tom Yan <tom.ty89@gmail.com> [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 80d732c..f70f9d1 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -4045,11 +4045,6 @@ void ata_scsi_simulate(struct ata_device *dev, struct scsi_cmnd *cmd) args.done = cmd->scsi_done; switch(scsicmd[0]) { - /* TODO: worth improving? */ - case FORMAT_UNIT: - ata_scsi_invalid_field(dev, cmd, 0); - break; - case INQUIRY: if (scsicmd[1] & 2) /* is CmdDt set? */ ata_scsi_invalid_field(dev, cmd, 1);