From patchwork Wed Jul 6 22:12:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Yan X-Patchwork-Id: 9217127 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4B46D6048B for ; Wed, 6 Jul 2016 22:12:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 30442284C6 for ; Wed, 6 Jul 2016 22:12:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2469A284CB; Wed, 6 Jul 2016 22:12:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B8AFD284C6 for ; Wed, 6 Jul 2016 22:12:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755752AbcGFWMs (ORCPT ); Wed, 6 Jul 2016 18:12:48 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:35395 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752522AbcGFWMr (ORCPT ); Wed, 6 Jul 2016 18:12:47 -0400 Received: by mail-pf0-f196.google.com with SMTP id t190so7781pfb.2; Wed, 06 Jul 2016 15:12:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:from:to:cc:subject:date; bh=vWzDzOC49dtdi5LgSQaevBwlVPf1qKVjnx+Ud7GLeEw=; b=BfTk9tkrJRQCN6YYnIdaI2sM7drK9Du91+fTMYwfPH2eOO6zUwW5eFevAj8sIqBD9n gZbH4W5ByULGOgkteFZSTzV6DjsVAxZ4CYK8OQN1Cka+Hxb2IKOASCBTHsNwymntmqHy 2cK37HqYdRuUzqhmm35tylN7fbz4soSqNeWncjcwonQx1jqy4Nbu4IExVK6p4YPpGNld zRJmSOo+uGwKADE6saiOcQVh+Z/bh5iI1TmexFTmSj5ycUME7XCAgYS+yI+5DxyGb3T7 pDA8NMpmurFAXr2ZOScCxHynONzGxT0/b6gjqLA1+KAE/ssFOPbrFqLwQBeoRqx5vRtQ mo5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:from:to:cc:subject:date; bh=vWzDzOC49dtdi5LgSQaevBwlVPf1qKVjnx+Ud7GLeEw=; b=Uqw8mwnMNzcUwaWGCOXlAhdBCIefl2xeVYkCpRXlhDdYenonVgXgDEUo2J1GEWvuBB 5DSYB/JbsQCM2LyQck0UTgTFiTCjhWw/PQdY79Vpsh1HnWC2FIrTv3ApxnWwsHd2seEk knn3z7J2hBs1Yv1j0RXvj3C1gLqAgRyLbUnmx6a7K/zEfbmEYjlv13Mmlyf+2CgGOhlu GTopBwFLEa++TRo464PUgXSiVZg5ZIiP/2EIX2AXCi9FRqZYk18bwoRFYtIjvuXGevnn x7UtJZylk/s3bCzagRIcIeE7Q22xE+qscg9FmWO8AYH3L5jvnuKsVfbIeaRZ2KGkaeGd +EOg== X-Gm-Message-State: ALyK8tINC0n8ggeOYZ5aOAy6eoFklOqVS10eMCDoWwt/SzkzQxByYHpt2RLid9hJCgdAlw== X-Received: by 10.98.73.198 with SMTP id r67mr46178407pfi.50.1467843145646; Wed, 06 Jul 2016 15:12:25 -0700 (PDT) Received: from localhost.localdomain ([2404:c805:e00:4700:ae22:bff:fe29:e60c]) by smtp.gmail.com with ESMTPSA id z1sm3989364pab.19.2016.07.06.15.12.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Jul 2016 15:12:25 -0700 (PDT) Message-ID: <577d8249.a10c420a.da50c.ffff953e@mx.google.com> X-Google-Original-Message-ID: <20160706221213.1928-1-me> From: tom.ty89@gmail.com X-Google-Original-From: me To: tj@kernel.org Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, Tom Yan Subject: [PATCH 1/2] libata-scsi: do not return designator for serial number Date: Thu, 7 Jul 2016 06:12:12 +0800 X-Mailer: git-send-email 2.9.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Tom Yan SAT (as of sat4r05f.pdf) does not require this vendor specific designator. Besides, we already have the Unit Serial Number VPD. Signed-off-by: Tom Yan diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index bfec66f..9f478ad 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -2210,14 +2210,6 @@ static unsigned int ata_scsiop_inq_83(struct ata_scsi_args *args, u8 *rbuf) rbuf[1] = 0x83; /* this page code */ num = 4; - /* piv=0, assoc=lu, code_set=ACSII, designator=vendor */ - rbuf[num + 0] = 2; - rbuf[num + 3] = ATA_ID_SERNO_LEN; - num += 4; - ata_id_string(args->id, (unsigned char *) rbuf + num, - ATA_ID_SERNO, ATA_ID_SERNO_LEN); - num += ATA_ID_SERNO_LEN; - /* SAT defined lu model and serial numbers descriptor */ /* piv=0, assoc=lu, code_set=ACSII, designator=t10 vendor id */ rbuf[num + 0] = 2;