From patchwork Tue Jul 12 13:29:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Yan X-Patchwork-Id: 9225319 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 89816604DB for ; Tue, 12 Jul 2016 13:29:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7AB72265F9 for ; Tue, 12 Jul 2016 13:29:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6F86027BFA; Tue, 12 Jul 2016 13:29:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 07567265F9 for ; Tue, 12 Jul 2016 13:29:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752591AbcGLN3p (ORCPT ); Tue, 12 Jul 2016 09:29:45 -0400 Received: from mail-pa0-f65.google.com ([209.85.220.65]:35049 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751972AbcGLN3o (ORCPT ); Tue, 12 Jul 2016 09:29:44 -0400 Received: by mail-pa0-f65.google.com with SMTP id dx3so1047478pab.2; Tue, 12 Jul 2016 06:29:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:from:to:cc:subject:date:in-reply-to:references; bh=ahDMEW2qH9h5ZozIByd2sOypfblEHxqeEgz0DQNJQu4=; b=OiPmqrJ+WP3VuKLt5E0mOxIzGY0XC5h3YzDE7hsoI95EYKTNZqp+QDcsx8YlDSF+1p +CeMJmSqRvKKcbHdzrP//UTCibBYsNFlplrYxK0Dt9eJAKnAtfx3dVfQRi/BO7Jn2ZjI RtTfxBQBhumKFNRCytRAMzrjKVrPBqqj0/a+JUgDj7ZDkym1xInyiFHThTfPHmFz2FJQ 1vV2pC9LbQl2YZZ+jx9tR+m2fB2ETPZKLgEjdPHDUiekFhdIq0uZ3cCbb0c9fU+neV1u pyVqlVtL4Yr8Evlee0Eu9luTlaOGtGB5Qu2Xq8b1C8U6eYarZ+zbSIxLxBcxheqJevTM sJrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:from:to:cc:subject:date:in-reply-to :references; bh=ahDMEW2qH9h5ZozIByd2sOypfblEHxqeEgz0DQNJQu4=; b=aSlwin+qAU+sQohwUy4JmykW3yi7fw9FP6jGnov8qtzREWNcnDA6gVhe/PcdnrT0Hi F1gQ+M2CUxFQP/hN01WthowZDUfjlYrOpPiWmKemD4bSz1bAKiYk2sVNTp6r12IIyFfx 5YpHyScnvAQKV+K7N7aeVhrT/c7J6mXHGVRBJvErgE0QkkUVQBKWT9nz5Bol4+s77ZBV HX4KMsDCDnfcaVJqsFozH0zUNalFzWzGuOyV+4HUNzjgYENyiuFyvTRnYj7HSiMvYvhR 3/QRIGxh8OJ2vKavcTQHst7RWGttIoA53YAgFgMZ1aUuCwcAVrMQAZzYuwibJ3ODecPe /EHg== X-Gm-Message-State: ALyK8tJ3do6X+RupiVf8IQ4AVA0TfGv8yCmzS7ED4JvGXEi/dG3Z2iWY7jWDBGoeVClbWQ== X-Received: by 10.66.43.7 with SMTP id s7mr4035147pal.27.1468330183957; Tue, 12 Jul 2016 06:29:43 -0700 (PDT) Received: from localhost.localdomain ([2404:c805:e00:4700:ae22:bff:fe29:e60c]) by smtp.gmail.com with ESMTPSA id e126sm4796076pfc.5.2016.07.12.06.29.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Jul 2016 06:29:43 -0700 (PDT) Message-ID: <5784f0c7.8469620a.ab9e4.ffff999d@mx.google.com> X-Google-Original-Message-ID: <20160712132935.1811-2-me> From: tom.ty89@gmail.com X-Google-Original-From: me To: tj@kernel.org Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, Tom Yan Subject: [PATCH resend 2/2] libata-scsi: correct SPC version descriptor Date: Tue, 12 Jul 2016 21:29:35 +0800 X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160712132935.1811-1-me> References: <20160712132935.1811-1-me> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Tom Yan The comment suggests we should be having an SPC-3 version descriptor but the 0260h is the code for "SPC-2 (no version claimed)". Correct it to 0300h so that it has the "SPC-3 (no version claimed)" descriptor. Note that we are claiming SPC-3 version compatibility in the VERSION field of the standard INQUIRY data. Therefore, I assume the typo was on the code but not on the comment. Signed-off-by: Tom Yan diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 0a35164..8221800 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -2075,8 +2075,8 @@ static unsigned int ata_scsiop_inq_std(struct ata_scsi_args *args, u8 *rbuf) 0x03, 0x20, /* SBC-2 (no version claimed) */ - 0x02, - 0x60 /* SPC-3 (no version claimed) */ + 0x03, + 0x00 /* SPC-3 (no version claimed) */ }; const u8 versions_zbc[] = { 0x00,