uas: set host status byte on data completion error

Commit Message

Shantanu Goel June 5, 2024, 9:52 p.m. UTC

Hi,

I have a disk enclosure which is prone to data completion errors during initialization and because the UAS driver
only sets the resid on a data completion error and not the host status byte, the SD driver ends up using invalid zero'ed data.
The attached patch against v6.6.32 fixes this by setting the host status byte to DID_ERROR so the SD driver will notice
the error and retry the command.

This bug is present in all stable kernels (4.19, 5.4, 5.15, 6.1, 6,6) and the current 6.9.3 kernel.

This is the behavior prior to applying the patch.

[   11.872824] sd 0:0:0:1: [sdf] tag#9 data cmplt err -75 uas-tag 1 inflight:
[   11.872826] sd 0:0:0:1: [sdf] tag#9 CDB: Read capacity(16) 9e 10 00 00 00 00 00 00 00 00 00 00 00 20 00 00
[   11.872830] sd 0:0:0:1: [sdf] Sector size 0 reported, assuming 512.
[   11.872995] sd 2:0:0:1: [sdn] Preferred minimum I/O size 4096 bytes
[   11.872996] sd 2:0:0:1: [sdn] Optimal transfer size 33553920 bytes not a multiple of preferred minimum block size (4096 bytes)
[   11.873466] sd 1:0:0:0: [sdd] tag#29 data cmplt err -75 uas-tag 1 inflight:
[   11.873468] sd 1:0:0:0: [sdd] tag#29 CDB: Read capacity(16) 9e 10 00 00 00 00 00 00 00 00 00 00 00 20 00 00
[   11.873472] sd 1:0:0:0: [sdd] Sector size 0 reported, assuming 512.
[   11.873824] sd 7:0:0:0: [sde] Attached SCSI disk
[   11.874064] sd 3:0:0:1: [sdk] tag#16 data cmplt err -75 uas-tag 1 inflight:
[   11.874065] sd 3:0:0:1: [sdk] tag#16 CDB: Read capacity(16) 9e 10 00 00 00 00 00 00 00 00 00 00 00 20 00 00
[   11.874070] sd 3:0:0:1: [sdk] Sector size 0 reported, assuming 512.
[   11.874465] sd 5:0:0:0: [sdo] tag#10 data cmplt err -75 uas-tag 1 inflight:
[   11.874466] sd 5:0:0:0: [sdo] tag#10 CDB: Read capacity(16) 9e 10 00 00 00 00 00 00 00 00 00 00 00 20 00 00
[   11.874474] sd 5:0:0:0: [sdo] Sector size 0 reported, assuming 512.
[   11.876151] sd 4:0:0:1: [sdj] tag#10 data cmplt err -75 uas-tag 2 inflight:
[   11.876153] sd 4:0:0:1: [sdj] tag#10 CDB: Read capacity(16) 9e 10 00 00 00 00 00 00 00 00 00 00 00 20 00 00
[   11.876158] sd 4:0:0:1: [sdj] Sector size 0 reported, assuming 512.


After applying the patch I no longer see the zero sector sizes above and all sizes are detected correctly despite
the presence of completion errors.

Thanks

Signed-off-by: Shantanu Goel <[e-mail]>

Comments

Oliver Neukum June 6, 2024, 6:30 a.m. UTC | #1

On 05.06.24 23:52, Shantanu Goel wrote:
> Hi,
Hi,

thank you for the patch. Good catch.
Could you submit in the form that the Docuemntation describes?
That is inline and not attached, with your sign off also
inline, preferably generated with the script?

	Regards
		Oliver

Shantanu Goel June 7, 2024, 3:20 a.m. UTC | #2

On 6/6/24 2:30 AM, Oliver Neukum wrote:

>
>
> On 05.06.24 23:52, Shantanu Goel wrote:
>> Hi,
> Hi,
>
> thank you for the patch. Good catch.
> Could you submit in the form that the Docuemntation describes?
> That is inline and not attached, with your sign off also
> inline, preferably generated with the script?
>
>     Regards
>         Oliver
>
>

Hi Oliver,


Thanks for your feedback.  I'll regenerate the patch with 
git-format-patch and resubmit it in a separate email.


Regards,

Shantanu

Patch

--- .orig/drivers/usb/storage/uas.c	2024-06-02 11:46:49.144457253 -0400
+++ linux-6.6.32-1.sg.1.el9.x86_64/drivers/usb/storage/uas.c	2024-06-02 11:44:21.523375517 -0400
@@ -422,6 +422,7 @@ 
 			uas_log_cmd_state(cmnd, "data cmplt err", status);
 		/* error: no data transfered */
 		scsi_set_resid(cmnd, sdb->length);
+		set_host_byte(cmnd, DID_ERROR);
 	} else {
 		scsi_set_resid(cmnd, sdb->length - urb->actual_length);
 	}