From patchwork Tue Mar 6 08:21:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Saxena X-Patchwork-Id: 10260933 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A41A66037E for ; Tue, 6 Mar 2018 08:21:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 96CF928E34 for ; Tue, 6 Mar 2018 08:21:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8BA1B28E91; Tue, 6 Mar 2018 08:21:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4FEF128E34 for ; Tue, 6 Mar 2018 08:21:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750782AbeCFIV0 (ORCPT ); Tue, 6 Mar 2018 03:21:26 -0500 Received: from mail-oi0-f66.google.com ([209.85.218.66]:42198 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbeCFIVZ (ORCPT ); Tue, 6 Mar 2018 03:21:25 -0500 Received: by mail-oi0-f66.google.com with SMTP id c18so14180609oiy.9 for ; Tue, 06 Mar 2018 00:21:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=Ge0sXjDIqPYfi9zqY6yDW/w9fD1xXL4T/XYAxpLESv8=; b=LYL/XmOdNWePlNKcaF+IkjxVvlhJ/+8nEg/8c2PQg0iXmtZdFL7W1m+VUW4aq+NpdJ w1EXjko3aJZkEqHD6vr3OB5lJteglv0ZnH4ZN3TCi0YBr+As9LXEDjPOlGP+Y/JqGlBO ijo8iqfWcFKFqXatlnrxQXI/W6Se7yY2ZG868= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=Ge0sXjDIqPYfi9zqY6yDW/w9fD1xXL4T/XYAxpLESv8=; b=TdYIqP9XuiQjFuqB5M7HtFHF83kZdItzMtViRY8NJIIAp04C/OyP1qEnqD6Jn7ISvA jYn+zc7DmizvCo4LEt+A7b47csx6SJpM1tDz20DwXBkxJCPW9vlgpI8l76T9PUCrogWj 9CYXk1JIJjsR8qipCUmqYLJKOD3Vv9U0YfGU/0vmnduVTCkdkNx+VZ4Womj0qsqIdyyh S4MKjWT1jKKl/YSTKtu30dbxUsMB4YzlfChSAUUY0oWXc7uj/tNpcSavXl+j1Doi4hZ+ lOSSTMtDuM8c6i1+tU8RYL5oCgFW8VcVXISk7ZiQn/Vm4I0f3yLNxLkgpCEpBmHmDUx7 eYFg== X-Gm-Message-State: AElRT7FeNY6yhzS9nr0TvArf1cODAgxMxLROhIzP2T4v6yiL6k8yF9Jo OOfR0seSwAV4GJ3g+bqoCo4coe4Pz5tjXwgE/bgswQ== X-Google-Smtp-Source: AG47ELvncAqeOA1yT+gkxkCBBkcsDsXEZaKBTSiocEBvGPE0PDGeBgpDpPivAc+/fMfXdojdQa46SLN/O6a9WBERoN4= X-Received: by 10.202.231.196 with SMTP id e187mr10793424oih.358.1520324485039; Tue, 06 Mar 2018 00:21:25 -0800 (PST) From: Sumit Saxena References: <20180215162506.GA9306@jordon-HP-15-Notebook-PC> In-Reply-To: <20180215162506.GA9306@jordon-HP-15-Notebook-PC> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQGK1VBRQn0XMfaoN6eFr4a885IpVKRUnNTA Date: Tue, 6 Mar 2018 13:51:23 +0530 Message-ID: <954eb43d5ad8a10ec25743d0f778ea1c@mail.gmail.com> Subject: RE: [PATCH] scsi: megaraid: Use dma_pool_zalloc() To: Souptick Joarder , Kashyap Desai , Shivasharan Srikanteshwara Cc: "PDL,MEGARAIDLINUX" , linux-scsi@vger.kernel.org Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP -----Original Message----- From: Souptick Joarder [mailto:jrdr.linux@gmail.com] Sent: Thursday, February 15, 2018 9:55 PM To: kashyap.desai@broadcom.com; sumit.saxena@broadcom.com; shivasharan.srikanteshwara@broadcom.com Cc: megaraidlinux.pdl@broadcom.com; linux-scsi@vger.kernel.org Subject: [PATCH] scsi: megaraid: Use dma_pool_zalloc() Use dma_pool_zalloc() instead of dma_pool_alloc + memset Signed-off-by: Souptick Joarder --- drivers/scsi/megaraid/megaraid_sas_base.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) cmd->sense = dma_pool_alloc(instance->sense_dma_pool, @@ -4038,7 +4038,6 @@ static int megasas_create_frame_pool(struct megasas_instance *instance) return -ENOMEM; } - memset(cmd->frame, 0, instance->mfi_frame_size); cmd->frame->io.context = cpu_to_le32(cmd->index); cmd->frame->io.pad_0 = 0; if ((instance->adapter_type == MFI_SERIES) && reset_devices) Acked-by: Sumit Saxena -- 1.9.1 diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index a71ee67..905ea36 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -4022,7 +4022,7 @@ static int megasas_create_frame_pool(struct megasas_instance *instance) cmd = instance->cmd_list[i]; - cmd->frame = dma_pool_alloc(instance->frame_dma_pool, + cmd->frame = dma_pool_zalloc(instance->frame_dma_pool, GFP_KERNEL, &cmd->frame_phys_addr);