From patchwork Tue Nov 14 14:04:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 10057705 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B839C601D3 for ; Tue, 14 Nov 2017 14:04:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9BC0D29756 for ; Tue, 14 Nov 2017 14:04:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 90936297A2; Tue, 14 Nov 2017 14:04:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0EC3329760 for ; Tue, 14 Nov 2017 14:04:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755385AbdKNOEt (ORCPT ); Tue, 14 Nov 2017 09:04:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40074 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753507AbdKNOEr (ORCPT ); Tue, 14 Nov 2017 09:04:47 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 43D3576543; Tue, 14 Nov 2017 14:04:47 +0000 (UTC) Received: from shalem.localdomain (ovpn-117-155.ams2.redhat.com [10.36.117.155]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 19AF78A9DA; Tue, 14 Nov 2017 14:04:45 +0000 (UTC) Subject: Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device To: Oliver Neukum , Alan Stern Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org, stable@vger.kernel.org References: <20171114140017.17782-1-hdegoede@redhat.com> From: Hans de Goede Message-ID: <9f0486e5-7ff7-b612-3465-04f47e8c2545@redhat.com> Date: Tue, 14 Nov 2017 15:04:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171114140017.17782-1-hdegoede@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 14 Nov 2017 14:04:47 +0000 (UTC) Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, On 14-11-17 15:00, Hans de Goede wrote: > Just like all previous UAS capable Seagate disk enclosures, this > one needs a US_FL_NO_ATA_1X quirk. > > Cc: stable@vger.kernel.org # 3.16 > Reported-by: Wido > Signed-off-by: Hans de Goede So far we've been adding quirks for Seagate drives on a one by one basis (I started this myself) hoping that one day they will fix their ATA_1X pass-through support. But that does not seem to be happening. Maybe we need to do something like this instead ? : Then we can remove a whole lot of quirks and we avoid future churn when new Seagate device ids show up. Regards, Hans > --- > drivers/usb/storage/unusual_uas.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h > index 2fe4fd336446..a1ddcbfb7323 100644 > --- a/drivers/usb/storage/unusual_uas.h > +++ b/drivers/usb/storage/unusual_uas.h > @@ -114,6 +114,13 @@ UNUSUAL_DEV(0x0bc2, 0xab21, 0x0000, 0x9999, > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > US_FL_NO_ATA_1X), > > +/* Reported-by: Wido */ > +UNUSUAL_DEV(0x0bc2, 0xab24, 0x0000, 0x9999, > + "Seagate", > + "BUP Slim BK", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > + US_FL_NO_ATA_1X), > + > /* Reported-by: G. Richard Bellamy */ > UNUSUAL_DEV(0x0bc2, 0xab2a, 0x0000, 0x9999, > "Seagate", > --- a/drivers/usb/storage/uas-detect.h +++ b/drivers/usb/storage/uas-detect.h @@ -111,6 +111,10 @@ static int uas_use_uas_driver(struct usb_interface *intf, } } + /* All Seagate disk enclosures have broken ATA pass-through support */ + if (le16_to_cpu(udev->descriptor.idVendor) == 0x0bc2) + flags |= US_FL_NO_ATA_1X; + usb_stor_adjust_quirks(udev, &flags); if (flags & US_FL_IGNORE_UAS) {