From patchwork Tue May 22 23:31:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 10419727 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 365CD6016C for ; Tue, 22 May 2018 23:32:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 25B7328DDE for ; Tue, 22 May 2018 23:32:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 196AE28DF1; Tue, 22 May 2018 23:32:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B1CF128DDE for ; Tue, 22 May 2018 23:32:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753100AbeEVXcB (ORCPT ); Tue, 22 May 2018 19:32:01 -0400 Received: from mail-vk0-f66.google.com ([209.85.213.66]:41823 "EHLO mail-vk0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753251AbeEVXb7 (ORCPT ); Tue, 22 May 2018 19:31:59 -0400 Received: by mail-vk0-f66.google.com with SMTP id 131-v6so12002398vkf.8 for ; Tue, 22 May 2018 16:31:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=OyTJx0mJyCr+pi//I0a/qSdzFYu0akV/kZUuXtpYRFM=; b=YLbxcGTVIaC6PSWffulH+jYoZusdPh/m/iQlfJ+34tTvR23Iu0FcOK9ZBakdMC6ofn WzPwXxQGFgOwmLKEzMlmkyUYJYTpuvr7/HG23sNFOsT0fJMQDFbrvUQFsodyQ9S0KD9c gnbouQS6hOIK/5LYmfuPM1Ojc2NBwo5E/EUG6OC3hMooTwhLG0u2h109m+Mo9FMyVlKx 0lHmp9LNWRDUByt7/u4Mrz1eqbS4NKnMrGKd8yolEe3IuR/8BCMEfp6xcJLlaCifCUuo sGAshzoKH01iGzZmyXrRWtfQjXS/eLwCOEbnIEk6itOfi52IlyUCr2qKpGPiisALTw0z 56dQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=OyTJx0mJyCr+pi//I0a/qSdzFYu0akV/kZUuXtpYRFM=; b=Zlpb9WUU7tOEw6MdtzQ6h9CVK/TIvgT7wcsxjIr7JXSZPJHfr7fyd+XzpazvnqCOYh KCz5pWpqoN8OKJp3ZsQotHmKl/sBR9y9sVJu1riwZUXcuKcQhi5bubMdg2AIM/UJ5JDH PSXb562teQOeO7jRfgjK9epERQyxlTU+rvi7Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=OyTJx0mJyCr+pi//I0a/qSdzFYu0akV/kZUuXtpYRFM=; b=Fn5DarSsXz8k7I3OzZSbY5n5bpR+x7nzr9/nqHkXZCuBLLOjdvjb2+zp9WxyXm/Kq5 zERzwIaobRU4LLzbEd/McYFzwpvkeq97RPl2sUwD0KlwcxsoCnS6Hc70NbyhvwVekfZ/ t97jUZ0BqN7IrH75x37YdQdRRmA7pPBrLP5iFQLeW7Aqf+nNmZctYwwWlenUs5xbl1n5 2zQKgsBLXH/krG57RE/AVqvkBlEdWEuYTSozFkV1SWTlDfsuO5b8XjIgLlpTd7KOQlQ/ 4+tz4f6uClcaml2ofMzWflQWcrHPnWeqDn5iPIxtkinTChp4ucO9HQXEn0hRaC/w6LN8 KVlw== X-Gm-Message-State: ALKqPweJHJBT5ZnpwhzJATiXGRGFcyk4XqcIYh0lbqu92TZxK+GmiX8A +ru5YCITecPxVVaq3oFfXlU3PsggtkAyDxvBn9tPOw== X-Google-Smtp-Source: AB8JxZop6iXPuWONpZapk31A62am/oiXXKQyTCxqigYW+ymL3GtYl271KxPFOA/4nw149VGulUCKplM55glsvTaHjfo= X-Received: by 2002:a1f:3096:: with SMTP id w144-v6mr332742vkw.121.1527031918492; Tue, 22 May 2018 16:31:58 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1f:bd1:0:0:0:0:0 with HTTP; Tue, 22 May 2018 16:31:57 -0700 (PDT) In-Reply-To: <8d4af5c4-96fa-54ee-d5c1-b887b1de5a3c@kernel.dk> References: <20180522181512.39316-1-keescook@chromium.org> <20180522181512.39316-4-keescook@chromium.org> <20180522183613.GA3784@infradead.org> <732f4249-5681-4a54-ec21-4ecc3d3a74e5@kernel.dk> <20180522191309.GA23615@infradead.org> <8d4af5c4-96fa-54ee-d5c1-b887b1de5a3c@kernel.dk> From: Kees Cook Date: Tue, 22 May 2018 16:31:57 -0700 X-Google-Sender-Auth: la2ZXY6LMvHf5sYEHvLwc0MCk0s Message-ID: Subject: Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI To: Jens Axboe Cc: Christoph Hellwig , "Martin K. Petersen" , James Bottomley , Tejun Heo , Borislav Petkov , "David S. Miller" , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , linux-block , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, LKML Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, May 22, 2018 at 12:16 PM, Jens Axboe wrote: > On 5/22/18 1:13 PM, Christoph Hellwig wrote: >> On Tue, May 22, 2018 at 01:09:41PM -0600, Jens Axboe wrote: >>> I think Martin and Christoph are objecting to moving the code to >>> block/scsi_ioctl.h. I don't care too much about where the code is, but >>> think it would be nice to have the definitions in a separate header. But >>> if they prefer just pulling in all of SCSI for it, well then I guess >>> it's pointless to move the header bits. Seems very heavy handed to me, >>> though. >> >> It might be heavy handed for the 3 remaining users of drivers/ide, > > Brutal :-) Heh. I noticed a similar sense buffer use in drivers/cdrom/cdrom.c too. Is this okay under the same considerations? >> but as long as that stuff just keeps working I'd rather worry about >> everyone else, and keep the scsi code where it belongs. > > Fine with me then, hopefully we can some day kill it off. I'll send a v2. I found a few other things to fix up (including the cdrom.c one). Thanks! -Kees diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig index ad9b687a236a..220ff321c102 100644 --- a/drivers/block/Kconfig +++ b/drivers/block/Kconfig @@ -79,7 +79,7 @@ config GDROM tristate "SEGA Dreamcast GD-ROM drive" depends on SH_DREAMCAST select CDROM - select BLK_SCSI_REQUEST # only for the generic cdrom code + select SCSI help A standard SEGA Dreamcast comes with a modified CD ROM drive called a "GD-ROM" by SEGA to signify it is capable of reading special disks @@ -345,7 +345,7 @@ config CDROM_PKTCDVD tristate "Packet writing on CD/DVD media (DEPRECATED)" depends on !UML select CDROM - select BLK_SCSI_REQUEST + select SCSI help Note: This driver is deprecated and will be removed from the kernel in the near future! diff --git a/drivers/block/paride/Kconfig b/drivers/block/paride/Kconfig index f8bd6ef3605a..7fdfcc5eaca5 100644 --- a/drivers/block/paride/Kconfig +++ b/drivers/block/paride/Kconfig @@ -27,7 +27,7 @@ config PARIDE_PCD tristate "Parallel port ATAPI CD-ROMs" depends on PARIDE select CDROM - select BLK_SCSI_REQUEST # only for the generic cdrom code + select SCSI ---help--- This option enables the high-level driver for ATAPI CD-ROM devices connected through a parallel port. If you chose to build PARIDE