diff mbox

dick.kennedy@broadcom.com , james.smart@broadcom.com, hare@suse.com, martin.petersen@oracle.com

Message ID CAHYXAn+hnnvv5GKuxm6qv4PGMhwBjxGr9O2pWbDnwYrTXmbsng@mail.gmail.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Vasyl Gomonovych Oct. 11, 2017, 8:57 a.m. UTC 
From 1d3f6e197b8f9027910bf4ab1e97e69e3d77faf9 Mon Sep 17 00:00:00 2001
From: Vasyl Gomonovych <gomonovych@gmail.com>
Date: Wed, 11 Oct 2017 10:47:03 +0200
Subject: [PATCH] scsi: lpfc: fix kzalloc-simple.cocci warnings

drivers/scsi/lpfc/lpfc_debugfs.c:5460:22-29: WARNING: kzalloc should
be used for phba -> nvmeio_trc, instead of kmalloc/memset
drivers/scsi/lpfc/lpfc_debugfs.c:2230:20-27: WARNING: kzalloc should
be used for phba -> nvmeio_trc, instead of kmalloc/memset

 Use kzalloc rather than kmalloc followed by memset with 0

Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
---
 drivers/scsi/lpfc/lpfc_debugfs.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)


@@ -5467,9 +5465,6 @@ static int lpfc_idiag_cmd_get(const char __user
*buf, size_t nbytes,
                         "nvmeio_trc buffer\n");
                 goto nvmeio_off;
             }
-            memset(phba->nvmeio_trc, 0,
-                   (sizeof(struct lpfc_debugfs_nvmeio_trc) *
-                   phba->nvmeio_trc_size));
             phba->nvmeio_trc_on = 1;
             phba->nvmeio_trc_output_idx = 0;
             phba->nvmeio_trc = NULL;
diff mbox

Patch

diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
index d50c481..2bf5ad3 100644
--- a/drivers/scsi/lpfc/lpfc_debugfs.c
+++ b/drivers/scsi/lpfc/lpfc_debugfs.c
@@ -2227,7 +2227,7 @@ 
     kfree(phba->nvmeio_trc);

     /* Allocate new trace buffer and initialize */
-    phba->nvmeio_trc = kmalloc((sizeof(struct lpfc_debugfs_nvmeio_trc) *
+    phba->nvmeio_trc = kzalloc((sizeof(struct lpfc_debugfs_nvmeio_trc) *
                     sz), GFP_KERNEL);
     if (!phba->nvmeio_trc) {
         lpfc_printf_log(phba, KERN_ERR, LOG_INIT,
@@ -2235,8 +2235,6 @@ 
                 "nvmeio_trc buffer\n");
         return -ENOMEM;
     }
-    memset(phba->nvmeio_trc, 0,
-           (sizeof(struct lpfc_debugfs_nvmeio_trc) * sz));
     atomic_set(&phba->nvmeio_trc_cnt, 0);
     phba->nvmeio_trc_on = 0;
     phba->nvmeio_trc_output_idx = 0;
@@ -5457,7 +5455,7 @@  static int lpfc_idiag_cmd_get(const char __user
*buf, size_t nbytes,
             phba->nvmeio_trc_size = lpfc_debugfs_max_nvmeio_trc;

             /* Allocate trace buffer and initialize */
-            phba->nvmeio_trc = kmalloc(
+            phba->nvmeio_trc = kzalloc(
                 (sizeof(struct lpfc_debugfs_nvmeio_trc) *
                 phba->nvmeio_trc_size), GFP_KERNEL);