From patchwork Wed Oct 11 08:57:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasyl Gomonovych X-Patchwork-Id: 9999083 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 30166602BF for ; Wed, 11 Oct 2017 08:57:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2165A28971 for ; Wed, 11 Oct 2017 08:57:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1666D28975; Wed, 11 Oct 2017 08:57:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8AE7D28971 for ; Wed, 11 Oct 2017 08:57:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756763AbdJKI5a (ORCPT ); Wed, 11 Oct 2017 04:57:30 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:54765 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755552AbdJKI52 (ORCPT ); Wed, 11 Oct 2017 04:57:28 -0400 Received: by mail-it0-f65.google.com with SMTP id 72so1967884itk.3 for ; Wed, 11 Oct 2017 01:57:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=ouVm0cmaQoFFIktnyjTUXQdVwUXvMYSj8ixAoGRa9gM=; b=ISoytibjyBAbwpmUUVFlpUfSmmjP+PRMCq3qGetX04hni8do8hxLuz/nfbsUD9vClm 8J3IeOToqJqcODMYHHI6Z0GQM5ITbMLm5I71yhGYBq7eAw+C4Sggq9w9VpCGqzD6eDUE 9pJ/MSOnrFsizq08ptJKgcEEsgekHJYNEPFKXeKIjvFV3IntAQxgNWLJkksSI6Y4L6Ed Z2nYscJ/k9iG2JbISxiGJkgemRWyGke9c4q4ykC8D6/brV0FOgFN3242Ekm3oWc0XDLC mt1D3136N0tddRPWrCyRaK0uvAZt4f14r+9C25ZZmf8V3yw26/DfOqUDdNxW8Iyr6m3j b8JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=ouVm0cmaQoFFIktnyjTUXQdVwUXvMYSj8ixAoGRa9gM=; b=I13PQ6xN6ewiIpEeqIgj8Krd7jfeEeKZh7LxjOQHw4MKy3mKDcqm3mod89/Vh+QcQD 6fFf1RTrwVGURDbeTpf7BBhifx8W7/OpfmjLUPzeZp9xv8KUxSqGuOSjlLFfESwGZrdT m0GCY7VunNFxEV51PKD/pirmDGkj9F+K50uXn5kSTBP/t/lfrnCWYRRfqpvtTjeGBoSt SRKUXf1wi9l1IcCLf9aCJ+P1dbBeMGjZWgWpbYxQLZoQToOkJesOPa3RZRgWKae1jGA4 gX04eMCJtnJdXIhW3RYk39KuFkrQfBLd18D7IIr2EvbbDjUlD853AEX9gwEQB5PBLwLX IkVQ== X-Gm-Message-State: AMCzsaVz2LYLQ+5nVRsLf7rgk2PCUYeymJAhBIqKU6iwWoNRTdc4Amyi cpeaOHKCHMXc0s2uNYjMGVvS4V7bXnioJwLIcgm34g== X-Google-Smtp-Source: AOwi7QCtzljEZcfuToNOLxKMrjPe1qPYP+EsDWheAHzEap7I9VBx48veAd/NtthizIcs1PNYeJ/chDqh4I4qIQGuTJ4= X-Received: by 10.36.29.208 with SMTP id 199mr22515395itj.40.1507712247962; Wed, 11 Oct 2017 01:57:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.33.151 with HTTP; Wed, 11 Oct 2017 01:57:27 -0700 (PDT) From: "Gomonovych, Vasyl" Date: Wed, 11 Oct 2017 10:57:27 +0200 Message-ID: Subject: dick.kennedy@broadcom.com , james.smart@broadcom.com, hare@suse.com, martin.petersen@oracle.com To: linux-scsi@vger.kernel.org Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From 1d3f6e197b8f9027910bf4ab1e97e69e3d77faf9 Mon Sep 17 00:00:00 2001 From: Vasyl Gomonovych Date: Wed, 11 Oct 2017 10:47:03 +0200 Subject: [PATCH] scsi: lpfc: fix kzalloc-simple.cocci warnings drivers/scsi/lpfc/lpfc_debugfs.c:5460:22-29: WARNING: kzalloc should be used for phba -> nvmeio_trc, instead of kmalloc/memset drivers/scsi/lpfc/lpfc_debugfs.c:2230:20-27: WARNING: kzalloc should be used for phba -> nvmeio_trc, instead of kmalloc/memset Use kzalloc rather than kmalloc followed by memset with 0 Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci --- drivers/scsi/lpfc/lpfc_debugfs.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) @@ -5467,9 +5465,6 @@ static int lpfc_idiag_cmd_get(const char __user *buf, size_t nbytes, "nvmeio_trc buffer\n"); goto nvmeio_off; } - memset(phba->nvmeio_trc, 0, - (sizeof(struct lpfc_debugfs_nvmeio_trc) * - phba->nvmeio_trc_size)); phba->nvmeio_trc_on = 1; phba->nvmeio_trc_output_idx = 0; phba->nvmeio_trc = NULL; diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c index d50c481..2bf5ad3 100644 --- a/drivers/scsi/lpfc/lpfc_debugfs.c +++ b/drivers/scsi/lpfc/lpfc_debugfs.c @@ -2227,7 +2227,7 @@ kfree(phba->nvmeio_trc); /* Allocate new trace buffer and initialize */ - phba->nvmeio_trc = kmalloc((sizeof(struct lpfc_debugfs_nvmeio_trc) * + phba->nvmeio_trc = kzalloc((sizeof(struct lpfc_debugfs_nvmeio_trc) * sz), GFP_KERNEL); if (!phba->nvmeio_trc) { lpfc_printf_log(phba, KERN_ERR, LOG_INIT, @@ -2235,8 +2235,6 @@ "nvmeio_trc buffer\n"); return -ENOMEM; } - memset(phba->nvmeio_trc, 0, - (sizeof(struct lpfc_debugfs_nvmeio_trc) * sz)); atomic_set(&phba->nvmeio_trc_cnt, 0); phba->nvmeio_trc_on = 0; phba->nvmeio_trc_output_idx = 0; @@ -5457,7 +5455,7 @@ static int lpfc_idiag_cmd_get(const char __user *buf, size_t nbytes, phba->nvmeio_trc_size = lpfc_debugfs_max_nvmeio_trc; /* Allocate trace buffer and initialize */ - phba->nvmeio_trc = kmalloc( + phba->nvmeio_trc = kzalloc( (sizeof(struct lpfc_debugfs_nvmeio_trc) * phba->nvmeio_trc_size), GFP_KERNEL);