| Message ID | Y7+oJuah0MgEW0PQ@ubun2204.myguest.virtualbox.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] scsi: qla2xxx: Simplify if condition evaluation | expand |
On Thu, Jan 12, 2023 at 11:56:46AM +0530, Deepak R Varma wrote: > A logical evaluation of type (!A || A && B) can be simplified as > (!A || B). > Improvement by suggested by excluded_middle.cocci Coccinelel semantic > patch. > > Signed-off-by: Deepak R Varma <drv@mailo.com> > --- Hello, May I request a review and feedback comment on this patch please? Thank you, ./drv > Please note: Change is compile tested only. > > Changes in v2: > - Correct the if evaluation from (A && B) to (!A || B). Feedback > from Lee Duncan <lduncan@suse.com> > > drivers/scsi/qla2xxx/qla_target.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c > index 548f22705ddc..4f104fbfe55d 100644 > --- a/drivers/scsi/qla2xxx/qla_target.c > +++ b/drivers/scsi/qla2xxx/qla_target.c > @@ -1028,8 +1028,7 @@ void qlt_free_session_done(struct work_struct *work) > } > > if (ha->flags.edif_enabled && > - (!own || (own && > - own->iocb.u.isp24.status_subcode == ELS_PLOGI))) { > + (!own || own->iocb.u.isp24.status_subcode == ELS_PLOGI)) { > sess->edif.authok = 0; > if (!ha->flags.host_shutting_down) { > ql_dbg(ql_dbg_edif, vha, 0x911e, > -- > 2.34.1 > > >
> On Jan 11, 2023, at 10:26 PM, Deepak R Varma <drv@mailo.com> wrote: > > A logical evaluation of type (!A || A && B) can be simplified as > (!A || B). > Improvement by suggested by excluded_middle.cocci Coccinelel semantic > patch. > > Signed-off-by: Deepak R Varma <drv@mailo.com> > --- > Please note: Change is compile tested only. > > Changes in v2: > - Correct the if evaluation from (A && B) to (!A || B). Feedback > from Lee Duncan <lduncan@suse.com> > > drivers/scsi/qla2xxx/qla_target.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c > index 548f22705ddc..4f104fbfe55d 100644 > --- a/drivers/scsi/qla2xxx/qla_target.c > +++ b/drivers/scsi/qla2xxx/qla_target.c > @@ -1028,8 +1028,7 @@ void qlt_free_session_done(struct work_struct *work) > } > > if (ha->flags.edif_enabled && > - (!own || (own && > - own->iocb.u.isp24.status_subcode == ELS_PLOGI))) { > + (!own || own->iocb.u.isp24.status_subcode == ELS_PLOGI)) { > sess->edif.authok = 0; > if (!ha->flags.host_shutting_down) { > ql_dbg(ql_dbg_edif, vha, 0x911e, > -- > 2.34.1 > > > Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com <mailto:himanshu.madhani@oracle.com>>
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 548f22705ddc..4f104fbfe55d 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -1028,8 +1028,7 @@ void qlt_free_session_done(struct work_struct *work) } if (ha->flags.edif_enabled && - (!own || (own && - own->iocb.u.isp24.status_subcode == ELS_PLOGI))) { + (!own || own->iocb.u.isp24.status_subcode == ELS_PLOGI)) { sess->edif.authok = 0; if (!ha->flags.host_shutting_down) { ql_dbg(ql_dbg_edif, vha, 0x911e,
A logical evaluation of type (!A || A && B) can be simplified as (!A || B). Improvement by suggested by excluded_middle.cocci Coccinelel semantic patch. Signed-off-by: Deepak R Varma <drv@mailo.com> --- Please note: Change is compile tested only. Changes in v2: - Correct the if evaluation from (A && B) to (!A || B). Feedback from Lee Duncan <lduncan@suse.com> drivers/scsi/qla2xxx/qla_target.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)