diff mbox

[3/4] target: Improve a size determination in three functions

Message ID a708f62c-6a03-9a10-e9e1-0a72e8953652@users.sourceforge.net (mailing list archive)
State Not Applicable
Headers show

Commit Message

SF Markus Elfring Nov. 4, 2017, 1:17 p.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 4 Nov 2017 13:35:08 +0100

Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/target/target_core_xcopy.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff mbox

Patch

diff --git a/drivers/target/target_core_xcopy.c b/drivers/target/target_core_xcopy.c
index 46cac36014df..1519e399392b 100644
--- a/drivers/target/target_core_xcopy.c
+++ b/drivers/target/target_core_xcopy.c
@@ -680,7 +680,7 @@  static int target_xcopy_read_source(
 	unsigned char cdb[16];
 	bool remote_port = (xop->op_origin == XCOL_DEST_RECV_OP);
 
-	xpt_cmd = kzalloc(sizeof(struct xcopy_pt_cmd), GFP_KERNEL);
+	xpt_cmd = kzalloc(sizeof(*xpt_cmd), GFP_KERNEL);
 	if (!xpt_cmd) {
 		pr_err("Unable to allocate xcopy_pt_cmd\n");
 		return -ENOMEM;
@@ -742,7 +742,7 @@  static int target_xcopy_write_destination(
 	unsigned char cdb[16];
 	bool remote_port = (xop->op_origin == XCOL_SOURCE_RECV_OP);
 
-	xpt_cmd = kzalloc(sizeof(struct xcopy_pt_cmd), GFP_KERNEL);
+	xpt_cmd = kzalloc(sizeof(*xpt_cmd), GFP_KERNEL);
 	if (!xpt_cmd) {
 		pr_err("Unable to allocate xcopy_pt_cmd\n");
 		return -ENOMEM;
@@ -1010,7 +1010,7 @@  sense_reason_t target_do_xcopy(struct se_cmd *se_cmd)
 		return TCM_PARAMETER_LIST_LENGTH_ERROR;
 	}
 
-	xop = kzalloc(sizeof(struct xcopy_op), GFP_KERNEL);
+	xop = kzalloc(sizeof(*xop), GFP_KERNEL);
 	if (!xop)
 		goto err;
 	xop->xop_se_cmd = se_cmd;