diff mbox series

elx: efct: fix zalloc-simple.cocci warnings

Message ID alpine.DEB.2.21.2004121734160.2419@hadrien (mailing list archive)
State Superseded
Headers show
Series elx: efct: fix zalloc-simple.cocci warnings | expand

Commit Message

Julia Lawall April 12, 2020, 3:38 p.m. UTC 
From: kbuild test robot <lkp@intel.com>

Use zeroing allocator rather than allocator followed by memset with 0

Generated by: scripts/coccinelle/api/alloc/zalloc-simple.cocci

CC: James Smart <jsmart2021@gmail.com>
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

There are four patches in all from 0-day, all with the same subject.
Maybe you can just squash them.

thanks,
julia

url:    https://github.com/0day-ci/linux/commits/James-Smart/efct-Broadcom-Emulex-FC-Target-driver/20200412-114125
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago

 efct_hw_queues.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff mbox series

Patch

--- a/drivers/scsi/elx/efct/efct_hw_queues.c
+++ b/drivers/scsi/elx/efct/efct_hw_queues.c
@@ -170,11 +170,10 @@  efct_hw_new_cq_set(struct hw_eq *eqs[],
 		cqs[i] = NULL;

 	for (i = 0; i < num_cqs; i++) {
-		cq = kmalloc(sizeof(*cq), GFP_KERNEL);
+		cq = kzalloc(sizeof(*cq), GFP_KERNEL);
 		if (!cq)
 			goto error;

-		memset(cq, 0, sizeof(*cq));
 		cqs[i]          = cq;
 		cq->eq          = eqs[i];
 		cq->type        = SLI_QTYPE_CQ;
@@ -373,11 +372,10 @@  efct_hw_new_rq_set(struct hw_cq *cqs[],
 		rqs[i] = NULL;

 	for (i = 0, q_count = 0; i < num_rq_pairs; i++, q_count += 2) {
-		rq = kmalloc(sizeof(*rq), GFP_KERNEL);
+		rq = kzalloc(sizeof(*rq), GFP_KERNEL);
 		if (!rq)
 			goto error;

-		memset(rq, 0, sizeof(*rq));
 		rqs[i] = rq;
 		rq->instance = hw->hw_rq_count++;
 		rq->cq = cqs[i];