diff mbox

mpt3sas: Do not mark fw_event workqueue as WQ_MEM_RECLAIM

Message ID bb0f5ebe547314c653a2b7d1ee86deb6@mail.gmail.com (mailing list archive)
State Accepted
Headers show

Commit Message

Sreekanth Reddy Feb. 28, 2018, 9:34 a.m. UTC 
-----Original Message-----
From: Hannes Reinecke [mailto:hare@suse.de]
Sent: Monday, February 26, 2018 7:56 PM
To: Martin K. Petersen
Cc: Christoph Hellwig; James Bottomley; linux-scsi@vger.kernel.org; Hannes
Reinecke; Sreekanth Reddy; Suganath Prabu Subramani; Hannes Reinecke
Subject: [PATCH] mpt3sas: Do not mark fw_event workqueue as WQ_MEM_RECLAIM

The firmware event workqueue should not be marked as WQ_MEM_RECLAIM as
it's doesn't need to make forward progress under memory pressure.
In the current state it will result in a deadlock if the device had been
forcefully removed.

Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Cc: Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
Signed-off-by: Hannes Reinecke <hare@suse.com>
---
 drivers/scsi/mpt3sas/mpt3sas_scsih.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

 		pr_err(MPT3SAS_FMT "failure at %s:%d/%s()!\n",
 		    ioc->name, __FILE__, __LINE__, __func__);
--
2.12.3

Acked-by: Sreekanth Reddy <Sreekanth.Reddy@broadcom.com>

Thanks,
Sreekanth
diff mbox

Patch

diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
index 74fca184dba9..b1d3218a7ad7 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
@@ -10547,7 +10547,7 @@  _scsih_probe(struct pci_dev *pdev, const struct
pci_device_id *id)
 	snprintf(ioc->firmware_event_name,
sizeof(ioc->firmware_event_name),
 	    "fw_event_%s%d", ioc->driver_name, ioc->id);
 	ioc->firmware_event_thread = alloc_ordered_workqueue(
-	    ioc->firmware_event_name, WQ_MEM_RECLAIM);
+	    ioc->firmware_event_name, 0);
 	if (!ioc->firmware_event_thread) {