From patchwork Sat Jul 16 20:24:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9233381 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6F73660865 for ; Sat, 16 Jul 2016 20:25:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6057A212D8 for ; Sat, 16 Jul 2016 20:25:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 55258212DB; Sat, 16 Jul 2016 20:25:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0E6D0212D8 for ; Sat, 16 Jul 2016 20:25:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751995AbcGPUZM (ORCPT ); Sat, 16 Jul 2016 16:25:12 -0400 Received: from mout.web.de ([217.72.192.78]:61066 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751666AbcGPUZJ (ORCPT ); Sat, 16 Jul 2016 16:25:09 -0400 Received: from [192.168.1.2] ([77.182.189.163]) by smtp.web.de (mrweb103) with ESMTPSA (Nemesis) id 0LecRm-1b0kNk49mQ-00qRud; Sat, 16 Jul 2016 22:24:55 +0200 Subject: [PATCH 3/3] xen-scsiback: Pass a failure indication as a constant To: xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , David Vrabel , Boris Ostrovsky References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <59e51c7d-f7bb-c55f-d2fe-06dccfef6a99@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: Date: Sat, 16 Jul 2016 22:24:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <59e51c7d-f7bb-c55f-d2fe-06dccfef6a99@users.sourceforge.net> X-Provags-ID: V03:K0:SFaEjbTRrXSLBP3FRcE3PLx3jBpVUBMW9LBzrSErCCPe4nUHkBD WbFUjK5kaKtboUVlBCCh0sQz7P7HnXBGcCv3ueHD9EqFxHOK7RX1GSQIl3Eo8xskk48/G3j mivhSzpoVa/fg1erP2thXGtAeBvEOH3wZ/JnALgEPVbEAHJseR5fh3FIoo86ddJ8fHuiNqx QsgiJn9NXLNC4P4vWbNOA== X-UI-Out-Filterresults: notjunk:1; V01:K0:u2lgqBc3ysE=:TpZJVui7fePbyxZCF2/7cd M2Pl/DPd9Dx6jDbmZhRLiWImFs+dcn+/arFxDsun89rzFHrelYwDuvEbgpEpG3sV44sZcvKXN u/+FRG1/nTyPrZerOJe0T/texJrMP4za4S49tBepXJSgvZagJ8A+/oFMQPLUBt7pQzcDOJmdM qPRsTAE+UQjTu6zrHWyJpa4Sg5lFZu5512c/SV2Jex19h6F3iWhNEhKUuGZ/6oeOO+/ecm9ot 8nnIxcqbmqnglwdTP6LqLdMjitLqat+QsOq0mfDgu2+s/evqEGplhNylSM8YmA2R5uc1N6AG7 kVefkc3XV8xnYeY0fExR03xEUWNUEU8BeqM851i7M+GtlW9VXmuH7d2XSw1V7HMuBrVQKO5RA Mgz4olgJOErmU5XQ49PIIXlRjVovdtfr6V/bwbIvR/cti4J5jK/51vB5dhjw3cr7X2pDaPfzU N4HFavyAyAmOFXrsGO77SIUP10xdsXVUVU3Sw3vEB5sd60L/XeKNQHHaDhj66HAQ016Dd0R+0 TYO351W3peACVjPhF7GU7JwNP3w4/+nwK/ddPCYsxym0tLRQE62uxSaZsPXrcZn2dfY6mh2hv 6HjfVbKi1mk8/PT0TozjR3KrsbN1bC0YGzKypqWxhNi79nz14msQGU4YlOZowB6q7yg57+AJN ELfZz9YB540KP7f8TvRZKU5O07M8wPByc8QjhgoZnUxYgenJqKRvnKv2BXfqptMo6Tt0a/FQR dNywZKG6sOCiXV2oT+YRLo+peL7YwYwS0iREzzoFHzss5JTEakK0lN/M68/ydb9vWnssnxubl KEAop2k Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Sat, 16 Jul 2016 21:55:01 +0200 Pass the constant "FAILED" in a function call directly instead of using an intialisation for a local variable. Signed-off-by: Markus Elfring Reviewed-by: Juergen Gross --- drivers/xen/xen-scsiback.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c index 7612bc9..ec5546c 100644 --- a/drivers/xen/xen-scsiback.c +++ b/drivers/xen/xen-scsiback.c @@ -601,7 +601,7 @@ static void scsiback_device_action(struct vscsibk_pend *pending_req, struct se_cmd *se_cmd = &pending_req->se_cmd; struct scsiback_tmr *tmr; u64 unpacked_lun = pending_req->v2p->lun; - int rc, err = FAILED; + int rc, err; tmr = kzalloc(sizeof(struct scsiback_tmr), GFP_KERNEL); if (!tmr) { @@ -629,7 +629,7 @@ static void scsiback_device_action(struct vscsibk_pend *pending_req, free_tmr: kfree(tmr); do_resp: - scsiback_do_resp_with_sense(NULL, err, 0, pending_req); + scsiback_do_resp_with_sense(NULL, FAILED, 0, pending_req); } /*