diff mbox series

qla2xxx: remove double assignment in qla2x00_update_fcport

Message ID e5419ee1-0ae8-2d55-666e-741efece90e6@suse.de (mailing list archive)
State Accepted
Headers show
Series qla2xxx: remove double assignment in qla2x00_update_fcport | expand

Commit Message

Enzo Matsumiya May 7, 2019, 3:39 p.m. UTC 
Remove double assignment in qla2x00_update_fcport().

Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
---
 drivers/scsi/qla2xxx/qla_init.c | 1 -
 1 file changed, 1 deletion(-)

        switch (vha->hw->current_topology) {
--
2.12.3

Comments

Martin K. Petersen May 30, 2019, 2:27 a.m. UTC | #1 
Himanshu?

> Remove double assignment in qla2x00_update_fcport().
>
> Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
> ---
>  drivers/scsi/qla2xxx/qla_init.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_init.c
> b/drivers/scsi/qla2xxx/qla_init.c
> index 0c700b140ce7..18078e215466 100644
> --- a/drivers/scsi/qla2xxx/qla_init.c
> +++ b/drivers/scsi/qla2xxx/qla_init.c
> @@ -5237,7 +5237,6 @@ qla2x00_update_fcport(scsi_qla_host_t *vha,
> fc_port_t *fcport)
>         fcport->flags &= ~(FCF_LOGIN_NEEDED | FCF_ASYNC_SENT);
>         fcport->deleted = 0;
>         fcport->logout_on_delete = 1;
> -       fcport->login_retry = vha->hw->login_retry_count;
>         fcport->n2n_chip_reset = fcport->n2n_link_reset_cnt = 0;
>
>         switch (vha->hw->current_topology) {
> --
> 2.12.3
>
>
Himanshu Madhani May 30, 2019, 4:46 a.m. UTC | #2 
On 5/29/19, 7:28 PM, "Martin K. Petersen" <martin.petersen@oracle.com> wrote:

    External Email
    
    ----------------------------------------------------------------------
    
    Himanshu?
    
    > Remove double assignment in qla2x00_update_fcport().
    >
    > Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
    > ---
    >  drivers/scsi/qla2xxx/qla_init.c | 1 -
    >  1 file changed, 1 deletion(-)
    >
    > diff --git a/drivers/scsi/qla2xxx/qla_init.c
    > b/drivers/scsi/qla2xxx/qla_init.c
    > index 0c700b140ce7..18078e215466 100644
    > --- a/drivers/scsi/qla2xxx/qla_init.c
    > +++ b/drivers/scsi/qla2xxx/qla_init.c
    > @@ -5237,7 +5237,6 @@ qla2x00_update_fcport(scsi_qla_host_t *vha,
    > fc_port_t *fcport)
    >         fcport->flags &= ~(FCF_LOGIN_NEEDED | FCF_ASYNC_SENT);
    >         fcport->deleted = 0;
    >         fcport->logout_on_delete = 1;
    > -       fcport->login_retry = vha->hw->login_retry_count;
    >         fcport->n2n_chip_reset = fcport->n2n_link_reset_cnt = 0;
    >
    >         switch (vha->hw->current_topology) {
    > --
    > 2.12.3
    >
    >
    
    -- 
    Martin K. Petersen	Oracle Linux Engineering
    

Sorry for delay.   Looks good. 

Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Martin K. Petersen June 5, 2019, 2:27 a.m. UTC | #3 
Enzo,

> Remove double assignment in qla2x00_update_fcport().

Applied to 5.3/scsi-queue, thanks!
diff mbox series

Patch

diff --git a/drivers/scsi/qla2xxx/qla_init.c
b/drivers/scsi/qla2xxx/qla_init.c
index 0c700b140ce7..18078e215466 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -5237,7 +5237,6 @@  qla2x00_update_fcport(scsi_qla_host_t *vha,
fc_port_t *fcport)
        fcport->flags &= ~(FCF_LOGIN_NEEDED | FCF_ASYNC_SENT);
        fcport->deleted = 0;
        fcport->logout_on_delete = 1;
-       fcport->login_retry = vha->hw->login_retry_count;
        fcport->n2n_chip_reset = fcport->n2n_link_reset_cnt = 0;