[0/8] Detach TPM space code out of the tpm_transmit() flow

Message

Jarkko Sakkinen Nov. 3, 2018, 5:07 p.m. UTC

Make the changes that are needed to detach TPM space code from
tpm_transmit() flow so that we do no longer need nested tpm_transmit()
calls.

v2:
* Print tpm2_commit_space() error inside tpm2_commit_space()
* Error code was not printed when recv() callback failed. It is
  fixed in this version.
* Added a patch that removes @space from tpm_transmit().
* Fixed a regression in earlier series. Forgot to amend the change
  from the staging area that renames NESTED to UNLOCKED in tpm2-space.c.

Jarkko Sakkinen (8):
  tpm: use tpm_buf in tpm_transmit_cmd() as the IO parameter
  tpm: print tpm2_commit_space() error inside tpm2_commit_space()
  tpm: clean up tpm_try_transmit() error handling flow
  tpm: access command header through struct in  tpm_try_transmit()
  tpm: move tpm_validate_commmand() to tpm2-space.c
  tpm: encapsulate tpm_dev_transmit()
  tpm: move TPM space code out of tpm_transmit()
  tpm: remove @space from tpm_transmit()

 drivers/char/tpm/tpm-dev-common.c |  50 ++++++-
 drivers/char/tpm/tpm-interface.c  | 240 +++++++++++-------------------
 drivers/char/tpm/tpm-sysfs.c      |   5 +-
 drivers/char/tpm/tpm.h            |  16 +-
 drivers/char/tpm/tpm1-cmd.c       |  28 +---
 drivers/char/tpm/tpm2-cmd.c       |  39 ++---
 drivers/char/tpm/tpm2-space.c     |  77 +++++++---
 drivers/char/tpm/tpm_vtpm_proxy.c |   3 +-
 8 files changed, 220 insertions(+), 238 deletions(-)

Comments

Winkler, Tomas Nov. 4, 2018, 7:46 a.m. UTC | #1

> Subject: [PATCH 0/8] Detach TPM space code out of the tpm_transmit() flow

You forgot to version your posts this should be V2 in the subject, right?
Thanks
Tomas

 
> Make the changes that are needed to detach TPM space code from
> tpm_transmit() flow so that we do no longer need nested tpm_transmit()
> calls.
> 
> v2:
> * Print tpm2_commit_space() error inside tpm2_commit_space()
> * Error code was not printed when recv() callback failed. It is
>   fixed in this version.
> * Added a patch that removes @space from tpm_transmit().
> * Fixed a regression in earlier series. Forgot to amend the change
>   from the staging area that renames NESTED to UNLOCKED in tpm2-space.c.
> 
> Jarkko Sakkinen (8):
>   tpm: use tpm_buf in tpm_transmit_cmd() as the IO parameter
>   tpm: print tpm2_commit_space() error inside tpm2_commit_space()
>   tpm: clean up tpm_try_transmit() error handling flow
>   tpm: access command header through struct in  tpm_try_transmit()
>   tpm: move tpm_validate_commmand() to tpm2-space.c
>   tpm: encapsulate tpm_dev_transmit()
>   tpm: move TPM space code out of tpm_transmit()
>   tpm: remove @space from tpm_transmit()
> 
>  drivers/char/tpm/tpm-dev-common.c |  50 ++++++-  drivers/char/tpm/tpm-
> interface.c  | 240 +++++++++++-------------------
>  drivers/char/tpm/tpm-sysfs.c      |   5 +-
>  drivers/char/tpm/tpm.h            |  16 +-
>  drivers/char/tpm/tpm1-cmd.c       |  28 +---
>  drivers/char/tpm/tpm2-cmd.c       |  39 ++---
>  drivers/char/tpm/tpm2-space.c     |  77 +++++++---
>  drivers/char/tpm/tpm_vtpm_proxy.c |   3 +-
>  8 files changed, 220 insertions(+), 238 deletions(-)
> 
> --
> 2.19.1

Jarkko Sakkinen Nov. 4, 2018, 4:25 p.m. UTC | #2

On Sun, Nov 04, 2018 at 07:46:43AM +0000, Winkler, Tomas wrote:
> > Subject: [PATCH 0/8] Detach TPM space code out of the tpm_transmit() flow
> 
> You forgot to version your posts this should be V2 in the subject, right?
> Thanks
> Tomas

Correct. Please hold with the review. I'll send soon v3.

/Jarkko