From patchwork Thu Jun 13 01:06:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaskaran Singh Khurana X-Patchwork-Id: 10993057 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0B4D614DB for ; Thu, 13 Jun 2019 16:57:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EE8E620881 for ; Thu, 13 Jun 2019 16:57:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E2BB022BF1; Thu, 13 Jun 2019 16:57:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A05420881 for ; Thu, 13 Jun 2019 16:57:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731634AbfFMQ5N (ORCPT ); Thu, 13 Jun 2019 12:57:13 -0400 Received: from linux.microsoft.com ([13.77.154.182]:54334 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729932AbfFMBGR (ORCPT ); Wed, 12 Jun 2019 21:06:17 -0400 Received: from jaskaran-Intel-Server-Board-S1200V3RPS-UEFI-Development-Kit.corp.microsoft.com (unknown [131.107.160.238]) by linux.microsoft.com (Postfix) with ESMTPSA id 2FC2720B7186; Wed, 12 Jun 2019 18:06:16 -0700 (PDT) From: Jaskaran Khurana To: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: agk@redhat.com, snitzer@redhat.com, dm-devel@redhat.com, jmorris@namei.org, scottsh@microsoft.com, ebiggers@google.com, mpatocka@redhat.com, jaskarankhurana@linux.microsoft.com Subject: [RFC PATCH v4 0/1] Add dm verity root hash pkcs7 sig validation. Date: Wed, 12 Jun 2019 18:06:09 -0700 Message-Id: <20190613010610.4364-1-jaskarankhurana@linux.microsoft.com> X-Mailer: git-send-email 2.17.1 Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: X-Virus-Scanned: ClamAV using ClamSMTP This patch set adds in-kernel pkcs7 signature checking for the roothash of the dm-verity hash tree. The verification is to support cases where the roothash is not secured by Trusted Boot, UEFI Secureboot or similar technologies. One of the use cases for this is for dm-verity volumes mounted after boot, the root hash provided during the creation of the dm-verity volume has to be secure and thus in-kernel validation implemented here will be used before we trust the root hash and allow the block device to be created. Why we are doing validation in the Kernel? The reason is to still be secure in cases where the attacker is able to compromise the user mode application in which case the user mode validation could not have been trusted. The root hash signature validation in the kernel along with existing dm-verity implementation gives a higher level of confidence in the executable code or the protected data. Before allowing the creation of the device mapper block device the kernel code will check that the detached pkcs7 signature passed to it validates the roothash and the signature is trusted by builtin keys set at kernel creation. The kernel should be secured using Verified boot, UEFI Secure Boot or similar technologies so we can trust it. What about attacker mounting non dm-verity volumes to run executable code? This verification can be used to have a security architecture where a LSM can enforce this verification for all the volumes and by doing this it can ensure that all executable code runs from signed and trusted dm-verity volumes. Further patches will be posted that build on this and enforce this verification based on policy for all the volumes on the system. How are these changes tested? To generate and sign the roothash just dump the roothash returned by veritysetup format in a text file and then sign using the tool in the topic branch here: (fsverity uses the tool for signing, I just added a parameter there for testing) https://github.com/jaskarankhurana/fsverity-sign/tree/fs_verity_detached_pkcs7_for_dm_verity fsverity sign-dm-verity --key= --cert= veritysetup part of cryptsetup library was modified to take a optional root-hash-sig parameter. Commandline used to test the changes: veritysetup open --root-hash-sig= The changes for veritysetup are in a topic branch for now at: https://github.com/jaskarankhurana/veritysetup/tree/veritysetup_add_sig Changelog: v4: - Code review feedback given by Milan Broz. - Add documentation about the root hash signature parameter. - Bump up the dm-verity target version. - Provided way to sign and test with veritysetup in cover letter. v3: - Code review feedback given by Sasha Levin. - Removed EXPORT_SYMBOL_GPL since this was not required. - Removed "This file is released under the GPLv2" since we have SPDX identifier. - Inside verity_verify_root_hash changed EINVAL to ENOKEY when the key descriptor is not specified but due to force option being set it is expected. - Moved CONFIG check to inside verity_verify_get_sig_from_key. (Did not move the sig_opts_cleanup to inside verity_dtr as the sig_opts do not need to be allocated for the entire duration the block device is active unlike the verity structure, note verity_dtr is called only if verity_ctr fails or after the lifetime of the block device.) v2: - Code review feedback to pass the signature binary blob as a key that can be looked up in the kernel and be used to verify the roothash. [Suggested by Milan Broz] - Made the code related change suggested in review of v1. [Suggested by Balbir Singh] v1: - Add kconfigs to control dm-verity root has signature verification and use the signature if specified to verify the root hash. Jaskaran Khurana (1): Adds in-kernel pkcs7 sig checking the roothash of the dm-verity hash tree Documentation/device-mapper/verity.txt | 7 ++ drivers/md/Kconfig | 23 +++++ drivers/md/Makefile | 2 +- drivers/md/dm-verity-target.c | 36 ++++++- drivers/md/dm-verity-verify-sig.c | 132 +++++++++++++++++++++++++ drivers/md/dm-verity-verify-sig.h | 30 ++++++ 6 files changed, 224 insertions(+), 6 deletions(-) create mode 100644 drivers/md/dm-verity-verify-sig.c create mode 100644 drivers/md/dm-verity-verify-sig.h