mbox series

[0/2] lsm: fix default return values for some hooks

Message ID 20231031123207.758655-1-omosnace@redhat.com (mailing list archive)
Headers show
Series lsm: fix default return values for some hooks | expand

Message

Ondrej Mosnacek Oct. 31, 2023, 12:32 p.m. UTC 
Some of the default return values listed in <linux/lsm_hook_defs.h>
don't match the actual no-op value and can be trivially fixed.

Ondrej Mosnacek (2):
  lsm: fix default return value for vm_enough_memory
  lsm: fix default return value for inode_getsecctx

 include/linux/lsm_hook_defs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Paul Moore Nov. 8, 2023, 3:12 a.m. UTC | #1 
On Tue, Oct 31, 2023 at 8:32 AM Ondrej Mosnacek <omosnace@redhat.com> wrote:
>
> Some of the default return values listed in <linux/lsm_hook_defs.h>
> don't match the actual no-op value and can be trivially fixed.
>
> Ondrej Mosnacek (2):
>   lsm: fix default return value for vm_enough_memory
>   lsm: fix default return value for inode_getsecctx
>
>  include/linux/lsm_hook_defs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

These both look like reasonable -stable candidates to me, what do you think?
Ondrej Mosnacek Nov. 8, 2023, 9:30 a.m. UTC | #2 
On Wed, Nov 8, 2023 at 4:12 AM Paul Moore <paul@paul-moore.com> wrote:
>
> On Tue, Oct 31, 2023 at 8:32 AM Ondrej Mosnacek <omosnace@redhat.com> wrote:
> >
> > Some of the default return values listed in <linux/lsm_hook_defs.h>
> > don't match the actual no-op value and can be trivially fixed.
> >
> > Ondrej Mosnacek (2):
> >   lsm: fix default return value for vm_enough_memory
> >   lsm: fix default return value for inode_getsecctx
> >
> >  include/linux/lsm_hook_defs.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
>
> These both look like reasonable -stable candidates to me, what do you think?

Yes, that would be my assessment as well.
Paul Moore Nov. 8, 2023, 9 p.m. UTC | #3 
On Wed, Nov 8, 2023 at 4:30 AM Ondrej Mosnacek <omosnace@redhat.com> wrote:
> On Wed, Nov 8, 2023 at 4:12 AM Paul Moore <paul@paul-moore.com> wrote:
> > On Tue, Oct 31, 2023 at 8:32 AM Ondrej Mosnacek <omosnace@redhat.com> wrote:
> > >
> > > Some of the default return values listed in <linux/lsm_hook_defs.h>
> > > don't match the actual no-op value and can be trivially fixed.
> > >
> > > Ondrej Mosnacek (2):
> > >   lsm: fix default return value for vm_enough_memory
> > >   lsm: fix default return value for inode_getsecctx
> > >
> > >  include/linux/lsm_hook_defs.h | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > These both look like reasonable -stable candidates to me, what do you think?
>
> Yes, that would be my assessment as well.

Okay, good.  I've just gone ahead and merged these into lsm/stable-6.7
and I'll plan to send them up to Linus on Thursday or Friday this
week.  Thanks.