diff mbox series

ima: remove CREDS_CHECK fall through

Message ID 1548957686-534-1-git-send-email-zohar@linux.ibm.com (mailing list archive)
State New, archived
Headers show
Series ima: remove CREDS_CHECK fall through | expand

Commit Message

Mimi Zohar Jan. 31, 2019, 6:01 p.m. UTC 
This patch fixes the CREDS_CHECK fall through as annotated in the
 "security mark expected switch fall-throughs" patch.

Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
Cc: Gustavo A. R. Silva <gustavo@embeddedor.com>
Cc: Matthew Garrett <mjg59@google.com>
---
 security/integrity/ima/ima_appraise.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Gustavo A. R. Silva Jan. 31, 2019, 6:08 p.m. UTC | #1 
Great!

Thanks for reviewing this, Mimi.

On 1/31/19 12:01 PM, Mimi Zohar wrote:
> This patch fixes the CREDS_CHECK fall through as annotated in the
>  "security mark expected switch fall-throughs" patch.
> 
> Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
> Cc: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Cc: Matthew Garrett <mjg59@google.com>

Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

> ---
>  security/integrity/ima/ima_appraise.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/security/integrity/ima/ima_appraise.c b/security/integrity/ima/ima_appraise.c
> index a2baa85ea2f5..5fb7127bbe68 100644
> --- a/security/integrity/ima/ima_appraise.c
> +++ b/security/integrity/ima/ima_appraise.c
> @@ -114,6 +114,7 @@ static void ima_set_cache_status(struct integrity_iint_cache *iint,
>  		break;
>  	case CREDS_CHECK:
>  		iint->ima_creds_status = status;
> +		break;
>  	case FILE_CHECK:
>  	case POST_SETATTR:
>  		iint->ima_file_status = status;
>
Matthew Garrett Jan. 31, 2019, 9:26 p.m. UTC | #2 
On Thu, Jan 31, 2019 at 10:02 AM Mimi Zohar <zohar@linux.ibm.com> wrote:
>
> This patch fixes the CREDS_CHECK fall through as annotated in the
>  "security mark expected switch fall-throughs" patch.
>
> Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
> Cc: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Cc: Matthew Garrett <mjg59@google.com>
Acked-by: Matthew Garrett <mjg59@google.com>
diff mbox series

Patch

diff --git a/security/integrity/ima/ima_appraise.c b/security/integrity/ima/ima_appraise.c
index a2baa85ea2f5..5fb7127bbe68 100644
--- a/security/integrity/ima/ima_appraise.c
+++ b/security/integrity/ima/ima_appraise.c
@@ -114,6 +114,7 @@  static void ima_set_cache_status(struct integrity_iint_cache *iint,
 		break;
 	case CREDS_CHECK:
 		iint->ima_creds_status = status;
+		break;
 	case FILE_CHECK:
 	case POST_SETATTR:
 		iint->ima_file_status = status;