From patchwork Wed Oct 4 10:27:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9984153 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 08AD060237 for ; Wed, 4 Oct 2017 10:27:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EB96328ACE for ; Wed, 4 Oct 2017 10:27:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E010128AD1; Wed, 4 Oct 2017 10:27:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 70EAB28ACE for ; Wed, 4 Oct 2017 10:27:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751223AbdJDK1f (ORCPT ); Wed, 4 Oct 2017 06:27:35 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:65010 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751114AbdJDK1e (ORCPT ); Wed, 4 Oct 2017 06:27:34 -0400 Received: from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id 0MXHhV-1dlgAI3Jwr-00WFYs; Wed, 04 Oct 2017 12:27:23 +0200 From: Arnd Bergmann To: David Howells , James Morris , "Serge E. Hallyn" Cc: Arnd Bergmann , =?UTF-8?q?Stephan=20M=C3=BCller?= , keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] security/keys: BIG_KEY requires CONFIG_CRYPTO Date: Wed, 4 Oct 2017 12:27:00 +0200 Message-Id: <20171004102722.1834761-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:K+6KKcS1D2iYDZpxeYognC8BCZvTaMKUZbFt0k2VtSq1RMHH2wn IAED6c/O17ZRBgbtQ+CWpSUqKDmNo+NOQcDu91AQowGx41cMEbQ/TUb4hGU40QQqjXsPIia fLS3bCEiImoRe3k4tCtoGD57GzHZtPT2NmsW+Vn7fogpKsbva5KegE8FpLDUSNaxUSykDj5 i7tl0xDMXI+rLC9I17EMw== X-UI-Out-Filterresults: notjunk:1; V01:K0:1xh3cEOtjZI=:NZ2zyoqbBbDNuYHW3oXUnk Xj7zYmRi8ZLQ89MHzCSeZDG15KuWzZbjuJ1zplAM/xEYNr41G0OeIYlqUTIaKxHiHPGVAXF1s Vv+y9KTeb0Rj10d2xjmBFynVj7ePC208o06VKzm2LfTX9uPbo7vhbZZMswOCK9iWwt4RHlC3f 1JerTQ+TPt/JL13YasBBgP7pf9YyaJQF7dhAfODhEUqZbgxx5zniAbzZSy6m24BMIYzj+6o3w T47/9mGYQhJabkQPtoxHoeAa/1QzVgeLEP5hrorBAtSz056iGl0MIS54kyBTzSnR9G6c2x4+r yUyczD+DFjd9z9sPCNFxLE3USUwyALeBX7s07kw475ItVmoH7Y8Ns1w2PBXQyCUD86Lq6mpu+ /U6F8IlZmB7/XWCVHEQq/vHJ/+h4UaOnv7lERxZ6zpPXWXwwcsAKeBTCEEtg52caDh96bLF/A HrsJ/jBWw8MohXbIDBpfdU9hKUlSUEqlWeN9A6w5CifgxgiJ7oY+9xGliAPQ9uX+N3HbmMV/i 6gkijiAhXl8NpJ13POaFlGgfLxXkeTy85JwAkj9NYllvn+VdVE3+JUJRdm5d9Gq6lQNPUWLDS NWkk1nU7bysq+fzWRCzLjQpj9dWgO+WyLRJv/zFRinnD4XhK4ovtvgL3atGVsZWlTQi539TwV GUAGKQ2ZCHf0ZNSd6kW24XDh6BQaFtNlze2nM3SEG91ZF3p97Y2EpTkdkY2mXq2+an46Fz/l9 79zHDP3S8LG1Du8TJpuc/AI7uXmdLORJDASDPw== Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: X-Virus-Scanned: ClamAV using ClamSMTP The recent rework introduced a possible randconfig build failure when CONFIG_CRYPTO configured to only allow modules: security/keys/big_key.o: In function `big_key_crypt': big_key.c:(.text+0x29f): undefined reference to `crypto_aead_setkey' security/keys/big_key.o: In function `big_key_init': big_key.c:(.init.text+0x1a): undefined reference to `crypto_alloc_aead' big_key.c:(.init.text+0x45): undefined reference to `crypto_aead_setauthsize' big_key.c:(.init.text+0x77): undefined reference to `crypto_destroy_tfm' crypto/gcm.o: In function `gcm_hash_crypt_remain_continue': gcm.c:(.text+0x167): undefined reference to `crypto_ahash_finup' crypto/gcm.o: In function `crypto_gcm_exit_tfm': gcm.c:(.text+0x847): undefined reference to `crypto_destroy_tfm' When we 'select CRYPTO' like the other users, we always get a configuration that builds. Fixes: 428490e38b2e ("security/keys: rewrite all of big_key crypto") Signed-off-by: Arnd Bergmann Reviewed-by: Serge Hallyn --- security/keys/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/security/keys/Kconfig b/security/keys/Kconfig index 91eafada3164..6462e6654ccf 100644 --- a/security/keys/Kconfig +++ b/security/keys/Kconfig @@ -45,6 +45,7 @@ config BIG_KEYS bool "Large payload keys" depends on KEYS depends on TMPFS + select CRYPTO select CRYPTO_AES select CRYPTO_GCM help