From patchwork Thu Aug 23 14:09:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10574081 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1F109139B for ; Thu, 23 Aug 2018 14:09:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 039C12C198 for ; Thu, 23 Aug 2018 14:09:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EBCA22C19D; Thu, 23 Aug 2018 14:09:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A11F2C19A for ; Thu, 23 Aug 2018 14:09:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730007AbeHWRjP (ORCPT ); Thu, 23 Aug 2018 13:39:15 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:47033 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728707AbeHWRjP (ORCPT ); Thu, 23 Aug 2018 13:39:15 -0400 Received: from wuerfel.lan ([109.193.40.16]) by mrelayeu.kundenserver.de (mreue003 [212.227.15.129]) with ESMTPA (Nemesis) id 0MNQ45-1fmXpx1VVZ-006vWg; Thu, 23 Aug 2018 16:09:20 +0200 From: Arnd Bergmann To: John Johansen , James Morris , "Serge E. Hallyn" Cc: Arnd Bergmann , Seth Arnold , Matthew Garrett , Kees Cook , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] apparmor: remove unused label Date: Thu, 23 Aug 2018 16:09:02 +0200 Message-Id: <20180823140917.3060915-1-arnd@arndb.de> X-Mailer: git-send-email 2.18.0 X-Provags-ID: V03:K1:grJHwwJTlK0rHz1G6OtWa7dTqG4vghsaujpdwcJpZn2z+yg/OfB U6XF1K03gwB5EApMxlnJhsCc3e86uIB4p0cwCnvguGW94gnvn2jOXwledMKrZqoiNSPnNci xDbRQDGNJaqqLGqoe5wFjLFEWPjBtymUdiXrlRlWvf9b6G5ypOcEwnEeTeNbcKVIZb1msTh P9Cr1l5r5yjrb0bOGrQZw== X-UI-Out-Filterresults: notjunk:1;V01:K0:fHQrGI7movw=:qYT0u/CFnx96h5Ae9EES1h 5xes1BjBYGCWrSGVppGs8/2G32NiW5K1E8Vc2GD6CLMPYZA6l+0wok0U7+bRPeczoJ+tW1UTg c2c6Jaa4eIkISc/WltTLu5CeHlyIrLti4GCmRpgQJ5s0oKwtAL56PPBDRzM41UuND2DBt4dI3 H+7xtG69EsFDJy0t2M4nrd0CtMXyqYkjeJKKj+vshXBTU2gHEosCoW+YD+f8B1pTqU8MNOPd7 Vzf2z5blFuF9T77Xbco05ssjj3Fe/aJ1aPXEcvm+veN29jMsOJeohZAxPVIANOf8u0gjaXnVr YdKLufeHHx2TacJ7OZ81h5joXtIkLk9ECfpKgD2c0g3CnblZFQ7kGxsfdqLhZI7MNbosVO2xF Rafs5xg+6GIQjz1D7rw+t0WMa2r6vsEJ+n3dL1xMOq8tBMOuXMPyoIK3kPQO4KfPFkJz0pPg9 RIm+aUzN+EWd75+sjdyO9mLQOZGHtWmyscnnd30hiPiha+imtLKyupvkHGEdsUdhCfCpHkShU 657CjXYx/kuvDddQmbZv8piic2lIgB8svWKQ640UsJwShAxgYMCeTULggO0Zb1PuKXAhQxojd 1Cv90D2wNKStSp0o2jxc5ER32nprrN14kOONbspJAh0j0QB/O8dTnn4sbzUeakjro94pnp8sb 385KrojIk4jd9qKTDJZFZXOYMPx6CzAM+HaYmL0oeeTZUBMpSKgrynGfqX6xQNvHcoqM= Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: X-Virus-Scanned: ClamAV using ClamSMTP After the corresponding 'goto' was removed, we get a warning for the 'fail' label: security/apparmor/policy_unpack.c: In function 'unpack_dfa': security/apparmor/policy_unpack.c:426:1: error: label 'fail' defined but not used [-Werror=unused-label] Fixes: fb5841091f28 ("apparmor: remove no-op permission check in policy_unpack") Signed-off-by: Arnd Bergmann Reviewed-by: Kees Cook --- security/apparmor/policy_unpack.c | 1 - 1 file changed, 1 deletion(-) diff --git a/security/apparmor/policy_unpack.c b/security/apparmor/policy_unpack.c index 3647b5834ace..96d8cf68ce65 100644 --- a/security/apparmor/policy_unpack.c +++ b/security/apparmor/policy_unpack.c @@ -423,7 +423,6 @@ static struct aa_dfa *unpack_dfa(struct aa_ext *e) return dfa; -fail: aa_put_dfa(dfa); return ERR_PTR(-EPROTO); }