| Message ID | 20201208100639.88182-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] apparmor: Remove duplicate macro list_entry_is_head() | expand |
On 12/8/20 2:06 AM, Andy Shevchenko wrote: > Strangely I hadn't had noticed the existence of the list_entry_is_head() in > apparmor code when added the same one in the list.h. Luckily it's fully > identical and didn't break builds. In any case we don't need a duplicate > anymore, thus remove it from apparmor code. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> oh nice, I will pull into the apparmor tree Acked-by: John Johansen <john.johansen@canonical.com> > --- > security/apparmor/apparmorfs.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c > index 5fd4a64e431f..f95c6bfa8b8e 100644 > --- a/security/apparmor/apparmorfs.c > +++ b/security/apparmor/apparmorfs.c > @@ -2046,9 +2046,6 @@ int __aafs_ns_mkdir(struct aa_ns *ns, struct dentry *parent, const char *name, > return error; > } > > - > -#define list_entry_is_head(pos, head, member) (&pos->member == (head)) > - > /** > * __next_ns - find the next namespace to list > * @root: root namespace to stop search at (NOT NULL) >
diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c index 5fd4a64e431f..f95c6bfa8b8e 100644 --- a/security/apparmor/apparmorfs.c +++ b/security/apparmor/apparmorfs.c @@ -2046,9 +2046,6 @@ int __aafs_ns_mkdir(struct aa_ns *ns, struct dentry *parent, const char *name, return error; } - -#define list_entry_is_head(pos, head, member) (&pos->member == (head)) - /** * __next_ns - find the next namespace to list * @root: root namespace to stop search at (NOT NULL)
Strangely I hadn't had noticed the existence of the list_entry_is_head() in apparmor code when added the same one in the list.h. Luckily it's fully identical and didn't break builds. In any case we don't need a duplicate anymore, thus remove it from apparmor code. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- security/apparmor/apparmorfs.c | 3 --- 1 file changed, 3 deletions(-)