| Message ID | 20220301120732.670168-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ima: remove redundant initialization of pointer 'file'. | expand |
On Tue, 2022-03-01 at 12:07 +0000, Colin Ian King wrote: > The pointer 'file' is being initialized with a value that is never read, > it is being re-assigned the same value later on closer to where it is > being first used. The initialization is redundant and can be removed. > > Cleans up clang scan build warning: > security/integrity/ima/ima_main.c:434:15: warning: Value stored to 'file' > during its initialization is never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> thanks, Mimi
diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c index c6412dec3810..41b91a0bc8dc 100644 --- a/security/integrity/ima/ima_main.c +++ b/security/integrity/ima/ima_main.c @@ -431,7 +431,7 @@ int ima_file_mmap(struct file *file, unsigned long prot) int ima_file_mprotect(struct vm_area_struct *vma, unsigned long prot) { struct ima_template_desc *template = NULL; - struct file *file = vma->vm_file; + struct file *file; char filename[NAME_MAX]; char *pathbuf = NULL; const char *pathname = NULL;
The pointer 'file' is being initialized with a value that is never read, it is being re-assigned the same value later on closer to where it is being first used. The initialization is redundant and can be removed. Cleans up clang scan build warning: security/integrity/ima/ima_main.c:434:15: warning: Value stored to 'file' during its initialization is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- security/integrity/ima/ima_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)