| Message ID | 20221109025019.1855-2-linux@weissschuh.net (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | certs: Prevent spurious errors on repeated blacklisting | expand |
On Wed, Nov 09, 2022 at 03:50:17AM +0100, Thomas Weißschuh wrote:
> Without this information these logs are not actionable.
Neither "more information" nor "this information" describe
"what information", right? :-)
BR, Jarkko
diff --git a/certs/blacklist.c b/certs/blacklist.c index 41f10601cc72..6e260c4b6a19 100644 --- a/certs/blacklist.c +++ b/certs/blacklist.c @@ -192,7 +192,7 @@ static int mark_raw_hash_blacklisted(const char *hash) KEY_ALLOC_NOT_IN_QUOTA | KEY_ALLOC_BUILT_IN); if (IS_ERR(key)) { - pr_err("Problem blacklisting hash (%ld)\n", PTR_ERR(key)); + pr_err("Problem blacklisting hash %s: %pe\n", hash, key); return PTR_ERR(key); } return 0;
Without this information these logs are not actionable. Fixes: 6364d106e041 ("certs: Allow root user to append signed hashes to the blacklist keyring") Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> --- certs/blacklist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)